-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon support to the <TabItem>
component
#1568
Conversation
🦋 Changeset detectedLatest commit: 07c6ab5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic! I have no notes (well, one tiny suggestion, but given how many notes I sometimes bother you with 😅) — I was thrown for a second by the indirection and then remembered how the tabs component works 😁
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I declare this iconic PR, ready for launch! 🚀
* main: [ci] format [ci] release (withastro#1574) Add `<Steps>` component (withastro#1564) Add `<FileTree>` component (withastro#1308) Add icon support to the `<TabItem>` component (withastro#1568) [ci] format docs: add Flojoy to showcase (withastro#1571) i18n(es): update `components` (withastro#1547) i18n(pt-PT): add "manual-setup" page (withastro#1570) i18n(zh-cn): Update pages.mdx (withastro#1565) Updates internal github actions to the latest versions (withastro#1569) [ci] format i18n(it): Update pages.mdx & plugins.mdx (withastro#1567) [ci] format i18n(pt-PT): add "environmental-impact" page (withastro#1561) [ci] format i18n(zh-cn): Update plugins.mdx (withastro#1566)
What kind of changes does this PR include?
Description
This PR adds support for a new optional
icon
prop to theTabItem
component. This prop can be used to add an icon to a tab to make it easier to visually distinguish between tabs.