Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon support to the <TabItem> component #1568

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Feb 28, 2024

What kind of changes does this PR include?

  • Changes to Starlight code

Description

This PR adds support for a new optional icon prop to the TabItem component. This prop can be used to add an icon to a tab to make it easier to visually distinguish between tabs.

image

Copy link

changeset-bot bot commented Feb 28, 2024

🦋 Changeset detected

Latest commit: 07c6ab5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Mar 1, 2024 9:12am

@github-actions github-actions bot added 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package labels Feb 28, 2024
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic! I have no notes (well, one tiny suggestion, but given how many notes I sometimes bother you with 😅) — I was thrown for a second by the indirection and then remembered how the tabs component works 😁

docs/src/content/docs/guides/components.mdx Outdated Show resolved Hide resolved
@delucis delucis added the 🌟 minor Change that triggers a minor release label Feb 29, 2024
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I declare this iconic PR, ready for launch! 🚀

@delucis delucis merged commit 5f99a71 into withastro:main Mar 1, 2024
9 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Mar 1, 2024
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Mar 2, 2024
* main:
  [ci] format
  [ci] release (withastro#1574)
  Add `<Steps>` component (withastro#1564)
  Add `<FileTree>` component (withastro#1308)
  Add icon support to the `<TabItem>` component (withastro#1568)
  [ci] format
  docs: add Flojoy to showcase (withastro#1571)
  i18n(es): update `components` (withastro#1547)
  i18n(pt-PT): add "manual-setup" page (withastro#1570)
  i18n(zh-cn): Update pages.mdx (withastro#1565)
  Updates internal github actions to the latest versions (withastro#1569)
  [ci] format
  i18n(it): Update pages.mdx & plugins.mdx (withastro#1567)
  [ci] format
  i18n(pt-PT): add "environmental-impact" page (withastro#1561)
  [ci] format
  i18n(zh-cn): Update plugins.mdx (withastro#1566)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes 🌟 minor Change that triggers a minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants