Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates internal github actions to the latest versions #1569

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Updates internal github actions to the latest versions #1569

merged 5 commits into from
Feb 29, 2024

Conversation

martrapp
Copy link
Member

Description

Get rid of those warnings:
image

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8ba9888

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Feb 29, 2024 2:45pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
starlight-i18n ⬜️ Ignored (Inspect) Feb 29, 2024 2:45pm

@github-actions github-actions bot added the 🚨 action Changes to GitHub Action workflows label Feb 28, 2024
@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Feb 28, 2024 •
edited
Loading

size-limit report 📦

Path Size
/index.html 5.23 KB (0%)
/_astro/*.js 21.54 KB (+0.02% 🔺)
/_astro/*.css 13.45 KB (0%)

kevinzunigacuellar
kevinzunigacuellar approved these changes Feb 28, 2024
View reviewed changes
Copy link
Sponsor Member

@kevinzunigacuellar kevinzunigacuellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Logs are looking nice (no warnings) and majors versions seem to have no breaking changes besides upgrading node 16 to 20.

@martrapp martrapp marked this pull request as draft February 29, 2024 12:00
@martrapp
Copy link
Member Author

I kept actions/labeler@v4 as updating to v5 requires a change of the configuration. This will be a PR on its own.

@martrapp martrapp marked this pull request as ready for review February 29, 2024 14:29
delucis
delucis requested changes Feb 29, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the careful updates @martrapp!

Just one note from me.

.changeset/fluffy-trains-rest.md Outdated Show resolved Hide resolved
delucis
delucis approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @martrapp — LGTM 🌟

@delucis delucis merged commit 585ac3f into main Feb 29, 2024
9 checks passed
@delucis delucis deleted the mt/deprecatedActions branch February 29, 2024 16:58
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Mar 2, 2024
@HiDeoo
Merge branch 'main' into hd-file-tree-docs
70fd3f6 
* main:
  [ci] format
  [ci] release (withastro#1574)
  Add `<Steps>` component (withastro#1564)
  Add `<FileTree>` component (withastro#1308)
  Add icon support to the `<TabItem>` component (withastro#1568)
  [ci] format
  docs: add Flojoy to showcase (withastro#1571)
  i18n(es): update `components` (withastro#1547)
  i18n(pt-PT): add "manual-setup" page (withastro#1570)
  i18n(zh-cn): Update pages.mdx (withastro#1565)
  Updates internal github actions to the latest versions (withastro#1569)
  [ci] format
  i18n(it): Update pages.mdx & plugins.mdx (withastro#1567)
  [ci] format
  i18n(pt-PT): add "environmental-impact" page (withastro#1561)
  [ci] format
  i18n(zh-cn): Update plugins.mdx (withastro#1566)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

@kevinzunigacuellar kevinzunigacuellar kevinzunigacuellar approved these changes

Assignees
No one assigned
Labels
🚨 action Changes to GitHub Action workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@martrapp @astrobot-houston @delucis @kevinzunigacuellar