Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(zh-cn): Update pages.mdx #1565

Merged
merged 3 commits into from
Feb 29, 2024
Merged

i18n(zh-cn): Update pages.mdx #1565

merged 3 commits into from
Feb 29, 2024

Conversation

liruifengv
Copy link
Member

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 63799d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Feb 29, 2024 5:14pm

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Feb 28, 2024
delucis
delucis approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @liruifengv! Left a suggestion but up to you if you want to do something with that — I’m happy either way.

docs/src/content/docs/zh-cn/guides/pages.mdx Outdated Show resolved Hide resolved
@liruifengv
Copy link
Member Author

I updated it. I think "Stub" can be left untranslated without affecting the overall reading

delucis
delucis approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @liruifengv! I’m happy if you are 🌠

@delucis delucis merged commit a8ea6f0 into withastro:main Feb 29, 2024
9 checks passed
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Mar 2, 2024
@HiDeoo
Merge branch 'main' into hd-file-tree-docs
70fd3f6 
* main:
  [ci] format
  [ci] release (withastro#1574)
  Add `<Steps>` component (withastro#1564)
  Add `<FileTree>` component (withastro#1308)
  Add icon support to the `<TabItem>` component (withastro#1568)
  [ci] format
  docs: add Flojoy to showcase (withastro#1571)
  i18n(es): update `components` (withastro#1547)
  i18n(pt-PT): add "manual-setup" page (withastro#1570)
  i18n(zh-cn): Update pages.mdx (withastro#1565)
  Updates internal github actions to the latest versions (withastro#1569)
  [ci] format
  i18n(it): Update pages.mdx & plugins.mdx (withastro#1567)
  [ci] format
  i18n(pt-PT): add "environmental-impact" page (withastro#1561)
  [ci] format
  i18n(zh-cn): Update plugins.mdx (withastro#1566)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liruifengv @delucis