Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nix icon #1628

Merged
merged 3 commits into from
Mar 20, 2024
Merged

add nix icon #1628

merged 3 commits into from
Mar 20, 2024

Conversation

o-az
Copy link
Contributor

@o-az o-az commented Mar 19, 2024

Description

Adds Nix icon

  • Closes #
  • What does this PR change? Give us a brief description.
  • Did you change something visual? A before/after screenshot can be helpful.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 48a23c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Mar 20, 2024 9:49am

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Mar 19, 2024
@at-the-vr
Copy link
Member

This Discussion thread is worth mentioning. Other than that I believe this will require a changeset 💡

delucis
delucis reviewed Mar 20, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @o-az! As @at-the-vr noted, we have had requests for this already and I think Nix makes sense to include.

Left one suggestion to optimise the path a little more for smaller file size. And I can take care of adding a “changeset” (which is how we organise our change logs and releases).

packages/starlight/components/Icons.ts Outdated Show resolved Hide resolved
@o-az @delucis
chore: squish down nix icon
cb9ee61 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@o-az
Copy link
Contributor Author

o-az commented Mar 20, 2024

Thank you @delucis for taking the time to review. I accepted your suggestion.

@delucis delucis added the 🌟 patch Change that triggers a patch release label Mar 20, 2024
delucis
delucis approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We’ll get this out in our next patch release.

@delucis delucis merged commit 24c0823 into withastro:main Mar 20, 2024
9 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Mar 20, 2024
Merged
@Eveeifyeve
Copy link
Contributor

Mentioned in discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@o-az @at-the-vr @Eveeifyeve @delucis