Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to props.css to the documentation #422

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Jul 28, 2023

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content

Description

As discussed on Discord, this PR adds a link to the list of Starlight CSS custom properties in the Custom CSS styles section of the docs.

This should be a good starting point for users looking for them until we get a more complete page for them considering that this link has already been shared a few times on Discord and I assume many people looked for it in the repo after not seeing it in the docs.

@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2023

⚠️ No Changeset found

Latest commit: 8bedd3e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 28, 2023

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 8bedd3e
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/64c43a54762b3a00070d9683
😎 Deploy Preview https://deploy-preview-422--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the 📚 docs Documentation website changes label Jul 28, 2023
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @HiDeoo! Going to tweak this slightly and make the link text a little more descriptive for anyone discovering it via assistive technology.

docs/src/content/docs/guides/customization.mdx Outdated Show resolved Hide resolved
@delucis delucis merged commit 6c38770 into withastro:main Jul 28, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants