Updating the tesla adapter protocols to use http1 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a well documented error with Tesla where the http2 cannot send more than 65535 bytes. The issue is documented here: elixir-tesla/tesla#394 This is a workaround until Tesla gets their workaround implemented.
rjacobse
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Looks good but we should def run this by @connorjacobsen as well
|
I ran this through locally with the digests, and it succeeded. At worst, this change should be neutral but @connorjacobsen when you're back on monday might be worth checking out |
|
What a weird bug. Maybe I'll see if I can fix it in Tesla... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a well documented error with Tesla where the http2 cannot send more than 65535 bytes. The issue is documented here: elixir-tesla/tesla#394
This is a workaround until Tesla gets their workaround implemented.