Skip to content

fix: adapt to breaking llama.cpp changes #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2025
Merged

fix: adapt to breaking llama.cpp changes #501

merged 1 commit into from
Sep 6, 2025

Conversation

o-u-p
Copy link
Contributor

@o-u-p o-u-p commented Sep 5, 2025 •
edited by giladgd
Loading

Description of change

  • fix: use flash_attn_type instead of legacy flash_attn

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

@giladgd giladgd changed the title fix: use flash_attn_type instead of legay flash_attn fix: adapt to breaking llama.cpp changes Sep 6, 2025
@giladgd giladgd merged commit 76b505e into withcatai:master Sep 6, 2025
24 checks passed
@giladgd
Copy link
Member

giladgd commented Sep 6, 2025

@o-u-p Thanks for the PR!

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2025

🎉 This PR is included in version 3.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giladgd giladgd giladgd approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@o-u-p @giladgd @nickname-yin