Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sed] Add Completion Spec #335

Merged
merged 2 commits into from
Jun 30, 2021
Merged

[Sed] Add Completion Spec #335

merged 2 commits into from
Jun 30, 2021

Conversation

ankithm28
Copy link
Contributor

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Completion Spec
What is the current behavior? (You can also link to an open issue here)
#102
What is the new behavior (if this is a feature change)?

Additional info:

@withfig-bot
Copy link
Collaborator

Overview

dev/sed.ts:

Info:

@withfig-bot
Copy link
Collaborator

Hello @monkeyank,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments have the arg property (arg: {})?
  • Are all options modular? E.g. a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

Copy link
Contributor

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the Sed CLI but this looks fine to me!

dev/sed.ts Outdated Show resolved Hide resolved
@ankithm28 ankithm28 requested a review from QuiiBz June 29, 2021 22:46
Copy link
Contributor

@QuiiBz QuiiBz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@QuiiBz QuiiBz merged commit 1d8c2e1 into withfig:master Jun 30, 2021
@QuiiBz QuiiBz mentioned this pull request Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants