Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete of like named directories is unintuitive #16

Closed
mathew-fleisch opened this issue Jan 21, 2021 · 8 comments
Closed

Autocomplete of like named directories is unintuitive #16

mathew-fleisch opened this issue Jan 21, 2021 · 8 comments
Assignees
Labels

Comments

@mathew-fleisch
Copy link
Contributor

mathew-fleisch commented Jan 21, 2021

Summary:
Autocomplete list orders like named folders in an unintuitive way for me. For instance, if you have a directory foo/ and a directory foo-bar/ the autocomplete menu will order foo-bar/ first, but with standard linux autocomplete tabbing I'd expect foo/ to come first. The rule should show the shortest match first.

@mathew-fleisch mathew-fleisch added the type:bug Something isn't working label Jan 21, 2021
@mschrage
Copy link
Member

This makes sense. Thanks for opening the issue!

@brendanfalk
Copy link
Member

@mathew-fleisch Totally agree.

We also sort suggestions based on recency of use when the user hasn't started filtering yet e.g. if you used foo-bar more recently than foo, then foo-bar will rank first. I don't think we will change this.

However, as soon as the user starts typing to filter, then we will order properly.

Does this seem good?

@mathew-fleisch
Copy link
Contributor Author

mathew-fleisch commented Jan 22, 2021

I wouldn't expect there to be a state. Personally, I'd want it to behave the same every time and be stateless. ¯\(ツ)

@mathew-fleisch
Copy link
Contributor Author

I said this in slack, but I'll say it here too. I would also turn this functionality off, if I could. The autocomplete for directories is not as useful as using it for complex commands that I may not remember the sub-commands for. Standard linux tabbing is faster (for me) to traverse files and directories, than having to use the arrow key to pick the correct directory/file. If this part of autocomplete cannot be turned off with some feature flag, I'd expect it to work exactly like linux tabbing to not disrupt my existing workflow. (my two cents)

@brendanfalk
Copy link
Member

brendanfalk commented Jan 22, 2021 via email

@mathew-fleisch
Copy link
Contributor Author

Cool. That works for me. Thanks! (Matt suggested this in slack as well, but I thought uninstall would remove autocomplete completely). I get it now 👍

@brendanfalk
Copy link
Member

Hey @mathew-fleisch - thinking about this. New tab autocomplete should feel more like standard shell autocomplete. We still do ordering based on recency of use and clicking tab multiple times does not traverse the directories.

Do things feel better now or are there changes that could be made to be even better? Lay it on us, we are happy to help

@brendanfalk brendanfalk changed the title [BUG] Autocomplete of like named directories is unintuitive Autocomplete of like named directories is unintuitive Apr 8, 2021
@mschrage
Copy link
Member

mschrage commented Aug 4, 2021

Closing this issue as stale + I think we've addressed this by adding the autocomplete.sortMethod setting which lets you specify recency or alphabetical.

@mschrage mschrage closed this as completed Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants