-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete of like named directories is unintuitive #16
Comments
This makes sense. Thanks for opening the issue! |
@mathew-fleisch Totally agree. We also sort suggestions based on recency of use when the user hasn't started filtering yet e.g. if you used However, as soon as the user starts typing to filter, then we will order properly. Does this seem good? |
I wouldn't expect there to be a state. Personally, I'd want it to behave the same every time and be stateless. ¯\(ツ)/¯ |
I said this in slack, but I'll say it here too. I would also turn this functionality off, if I could. The autocomplete for directories is not as useful as using it for complex commands that I may not remember the sub-commands for. Standard linux tabbing is faster (for me) to traverse files and directories, than having to use the arrow key to pick the correct directory/file. If this part of autocomplete cannot be turned off with some feature flag, I'd expect it to work exactly like linux tabbing to not disrupt my existing workflow. (my two cents) |
Understood. In our new update, you can actually uninstall specs. First you'll need to run `fig update` to get the most up to date specs
Then you can run `fig uninstall <spec>`.
e.g.
* `fig uninstall cd`
* `fig uninstall dotslash`
Uninstalling both of these will turn off file and folder completions for cd (and executables like "./script"), but not for all file / folder completions (ie it will still do it for `git add <filepath>`)
However, making a feature flag to turn off file completions everywhere is something we can do.
Brendan Falk
Co-founder & CEO @ Fig
brendan@withfig.com
(857) 800-1383
…On Fri, Jan 22, 2021 at 12:37:08, Mathew Fleisch < ***@***.*** > wrote:
I said this in slack, but I'll say it here too. I would also turn this
functionality off, if I could. The autocomplete for directories is not as
useful as using it for complex commands that I may not remember the
sub-commands for. Standard linux tabbing is faster (for me) to traverse
files and directories, than having to use the arrow key to pick the
correct directory/file. If this part of autocomplete cannot be turned off
with some feature flag, I'd expect it to work exactly like linux tabbing
to not disrupt my existing workflow. (my two cents)
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub (
#16 (comment) ) , or unsubscribe
(
https://github.com/notifications/unsubscribe-auth/ABFYIVBL5SAFBBSAPW5ZNE3S3HOXJANCNFSM4WNKAV2A
).
|
Cool. That works for me. Thanks! (Matt suggested this in slack as well, but I thought uninstall would remove autocomplete completely). I get it now 👍 |
Hey @mathew-fleisch - thinking about this. New tab autocomplete should feel more like standard shell autocomplete. We still do ordering based on recency of use and clicking tab multiple times does not traverse the directories. Do things feel better now or are there changes that could be made to be even better? Lay it on us, we are happy to help |
Closing this issue as stale + I think we've addressed this by adding the |
Summary:
Autocomplete list orders like named folders in an unintuitive way for me. For instance, if you have a directory
foo/
and a directoryfoo-bar/
the autocomplete menu will orderfoo-bar/
first, but with standard linux autocomplete tabbing I'd expectfoo/
to come first. The rule should show the shortest match first.The text was updated successfully, but these errors were encountered: