-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve timelock ux #1702
fix: improve timelock ux #1702
Conversation
2bbb3a3
to
47c021a
Compare
Can we use |
Trying to think of similar UIs, I tend to think that it is customary to place the advanced options after the "Advanced options" toggle label, so it feels that those options are somehow "contained" inside a section that was initially collapsed. In other words, when I click "Advanced options", I'm always expecting the options to appear down below. |
The "Now" option inside the date picker seems redundant to me. If we can't remove it, I'd rename it to "No timelock" (of course, using the current date as timelock will equal no timelock in practice). As the timelock is an optional feature and has two very clearly differentiated valid values (no date vs. some date), I'd also appreciate a quick way to clear this field. Something like an |
00b5c28
to
c4abf89
Compare
cd2694b
to
2da10a8
Compare
This pr implements the suggestions from discussion #1701.
The element-UI locale updates itself when the language changes and the date-picker input is hidden now behind the advance options button.