Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve timelock ux #1702

Merged
merged 3 commits into from
Jun 11, 2021
Merged

fix: improve timelock ux #1702

merged 3 commits into from
Jun 11, 2021

Conversation

gabaldon
Copy link
Contributor

@gabaldon gabaldon commented Jun 8, 2021

This pr implements the suggestions from discussion #1701.
The element-UI locale updates itself when the language changes and the date-picker input is hidden now behind the advance options button.

Captura de pantalla 2021-06-08 a las 15 48 18

Captura de pantalla 2021-06-08 a las 15 48 40

@gabaldon gabaldon force-pushed the fix-timelock-ux branch 2 times, most recently from 2bbb3a3 to 47c021a Compare June 8, 2021 14:51
@aesedepece
Copy link
Member

Can we use and or and on the "Advanced options" label? I think it helps understanding that it can be toggled on / off.

@aesedepece
Copy link
Member

aesedepece commented Jun 8, 2021

Trying to think of similar UIs, I tend to think that it is customary to place the advanced options after the "Advanced options" toggle label, so it feels that those options are somehow "contained" inside a section that was initially collapsed. In other words, when I click "Advanced options", I'm always expecting the options to appear down below.

@aesedepece
Copy link
Member

The "Now" option inside the date picker seems redundant to me.

If we can't remove it, I'd rename it to "No timelock" (of course, using the current date as timelock will equal no timelock in practice).

As the timelock is an optional feature and has two very clearly differentiated valid values (no date vs. some date), I'd also appreciate a quick way to clear this field. Something like an x inside the text box or next to it would work for me.

clbartoli
clbartoli previously approved these changes Jun 9, 2021
src/store/wallet.js Outdated Show resolved Hide resolved
src/store/wallet.js Outdated Show resolved Hide resolved
@gabaldon gabaldon merged commit 2da10a8 into witnet:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants