-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commitizen and commitlinter #69
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to guarantee that GitHub rejects commits not abiding by our guidelines Related to witnet#63
kronolynx
approved these changes
Jun 1, 2018
This is still not ready to be merged. I need yet to clean up my commits and
rebase it all.
…On Fri, 1 Jun 2018 10:35 Johann Og, ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#69 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQWV2_MfGIyB7lajtfshkX5vYQlWkRaks5t4PzlgaJpZM4UVFIe>
.
|
…en-and-commitlint
…en-and-commitlint
…en-and-commitlint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn fmt-verify
.Why this change is necessary and useful
As suggested by @mariocao and discussed in #63, this PR adds commitizen to our project. It also adds commitlinter to guarantee that GitHub rejects PRs with commit messages not abiding by our guidelines.
Implications
All commits should now abide by Angular's conventional changelog convention.
Why this PR doesn't include tests
No actual testable code was modified—only configuration files.