Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commitizen and commitlinter #69

Merged
merged 7 commits into from
Jun 4, 2018
Merged

Conversation

aesedepece
Copy link
Member

@aesedepece aesedepece commented May 31, 2018

  • I have read and understood docs/CODE_OF_CONDUCT document.
  • I have read and understood docs/styleguide document.
  • I have included tests for the changes in my PR. If not, I have included a rationale for why I haven't.
  • My code is formatted and is accepted by yarn fmt-verify.
  • I understand my PR may be closed if it becomes obvious I didn't actually perform all of these steps.

Why this change is necessary and useful

As suggested by @mariocao and discussed in #63, this PR adds commitizen to our project. It also adds commitlinter to guarantee that GitHub rejects PRs with commit messages not abiding by our guidelines.

Implications

All commits should now abide by Angular's conventional changelog convention.

Why this PR doesn't include tests

No actual testable code was modified—only configuration files.

@aesedepece
Copy link
Member Author

aesedepece commented Jun 1, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 📈 New feature or request WIP 💣
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants