Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add a .node-version file #80

Merged
merged 1 commit into from
Jun 5, 2018
Merged

build: add a .node-version file #80

merged 1 commit into from
Jun 5, 2018

Conversation

anler
Copy link
Contributor

@anler anler commented Jun 5, 2018

add a .node-version so we are all in the same page. I was using version 10 and bignum is no
compiling in it at the moment.

fix #79

PR Prelude

Thank you for contributing to sheikah! :)

Please fill in this template (by putting an x inside
the brackets) before filing your PR:

  • I have read and understood CODE_OF_CONDUCT document.
  • I have read and understood CONTRIBUTING document.
  • I have read and understood docs/styleguide document.
  • I have included tests for the changes in my PR. If not, I have included a
    rationale for why I haven't.
  • My code is formatted and is accepted by yarn fmt-verify.
  • I understand my PR may be closed if it becomes obvious I didn't
    actually perform all of these steps.

Why this change is necessary and useful

[Please explain in detail why the changes in this PR are needed.]

It helps to avoid opened issues due to people using different node versions.

add a .node-version so we are all in the same page. I was using version 10 and bignum is no
compiling in it at the moment.

fix #79
@anler anler merged commit e8b02c6 into witnet:master Jun 5, 2018
@anler anler deleted the node-version branch June 5, 2018 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build(node): add a .node-version with the version used in the project
2 participants