Include median in master #2068
Merged
Include median in master #2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was already reviewed in #2049 |
tmpolaczyk
reviewed
Sep 14, 2021
| assert!(!config_oppose_0016.tapi.oppose_wip0014); | ||
| assert!(config_oppose_0016.tapi.oppose_wip0016); | ||
| assert!(!empty_config.tapi.oppose_wip0017); | ||
| assert!(config_oppose_0017.tapi.oppose_wip0017); |
There was a problem hiding this comment.
This test was also used to check that unset fields default to false. Can you add something like that again?
assert!(!empty_config.tapi.oppose_wip0018);
assert!(!config_oppose_0017.tapi.oppose_wip0018);
So... approved!! :P |
tmpolaczyk
reviewed
Sep 14, 2021
| assert_eq!(epoch, init_epoch_wip0014); | ||
| // The first block whose vote must be counted is the one from WIP0017-0018-0019 | ||
| let init_epoch_wip0017_18_19 = 656640; | ||
| assert_eq!(epoch, init_epoch_wip0017_18_19); | ||
| // The TapiEngine was just created, there list of old_wips must be empty | ||
| assert_eq!(old_wips, HashSet::new()); | ||
| // The list of active WIPs only contains the first, second, and third hard forks |
There was a problem hiding this comment.
Suggested change
| // The list of active WIPs only contains the first, second, and third hard forks | |
| // The list of active WIPs should match those defined in `wip_info` |
tmpolaczyk
reviewed
Sep 14, 2021
rad/src/script.rs
Outdated
Comment on lines
221
to
227
| let active_wips = if let Some(active_wips) = active_wips { | ||
| active_wips.clone() | ||
| } else { | ||
| current_active_wips() | ||
| }; |
There was a problem hiding this comment.
I think this clone can be avoided, by doing something like this:
Suggested change
| let active_wips = if let Some(active_wips) = active_wips { | |
| active_wips.clone() | |
| } else { | |
| current_active_wips() | |
| }; | |
| let current_wips; | |
| let active_wips = if let Some(active_wips) = active_wips { | |
| active_wips | |
| } else { | |
| current_wips = current_active_wips(); | |
| ¤t_wips | |
| }; |
lrubiorod
force-pushed
the
include_median
branch
from
e96c02b
to
e6778f0
Compare
lrubiorod
force-pushed
the
include_median
branch
from
e6778f0
to
18b3410
Compare
tmpolaczyk
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.