Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VSCode FileSystem Provider #25

Open
bogobogo opened this issue May 4, 2020 · 4 comments
Open

Use VSCode FileSystem Provider #25

bogobogo opened this issue May 4, 2020 · 4 comments
Labels

Comments

@bogobogo
Copy link
Collaborator

bogobogo commented May 4, 2020

https://code.visualstudio.com/api/references/vscode-api#FileSystemProvider

@bogobogo bogobogo added the VSCode label May 4, 2020
@bradydowling
Copy link
Contributor

What is Codio currently using instead of this?

@bogobogo
Copy link
Collaborator Author

The very ugly FSManager class: https://github.com/wix-incubator/codio/blob/master/vscode/src/filesystem/FSManager.ts
I am basically using the fs, path and os libraries directly from node to modify the filesystem. FileSystemProvider was added after my initial POC and it provides a lot of the same functionality.

@bradydowling
Copy link
Contributor

bradydowling commented Jul 1, 2020

Awesome, thanks. Is there a level of permission you could give me to the repo just so I can push branches to make PRs directly on it? I don't want to over assert myself, just don't like to maintain a forked repo very much :) But I can definitely continue to do that if that's too much to ask.

Edit: Ok if not, no worries, just followed this guide for syncing a fork and it seems like it'll not require much effort from here.

@bogobogo
Copy link
Collaborator Author

bogobogo commented Jul 1, 2020

I will check in with the team and get back to you on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants