feat: improved typings for translate function so now it returns string instead of any #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varzager
reviewed
Mar 24, 2021
README.md
Outdated
| @@ -99,7 +101,9 @@ import React, {createContext, useContext, FC,} from 'react'; | |||
|
|
|||
| export type ILocaleKeys = ReturnType<typeof LocaleKeys>; | |||
|
|
|||
| export function LocaleKeys(translate: Function) { | |||
| type AbstractTranslateFunction = (key: string) => string; | |||
There was a problem hiding this comment.
I think u meant to write here like in the localeKeysFunction.template.ts :
type AbstractTranslateFunction = (...args: any[]) => string;
There was a problem hiding this comment.
hmmm yes...
gimme some time
I will try to infer the return type properly to address the concern you shared on slack (that someone could use the object in return type)
There was a problem hiding this comment.
i see you updated below the actual template code.
maybe update the readme as well?
|
hey @varzager seems like aligning the type to the return type of the i18next is the best option to avoid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.