Android API 32, 33 (v12): .tap() acts like tap+hold #3762

sergtimosh · 2022-12-16T21:49:01Z

What happened?

When detox tests executed against devices/emulators with API 33 level .tap() function acts like tap + hold(unreleased tap)

What was the expected behaviour?

tap should release

Was it tested on latest Detox?

I have tested this issue on the latest Detox release and it still reproduces.

Did your test throw out a timeout?

I have followed the instructions under Identifying which synchronization mechanism causes us to wait too much.

Help us reproduce this issue!

No response

In what environment did this happen?

Detox version: 20.1.0
React Native version: 0.68.2
Node version: 16.14.0
Device model: pixel 6a
Android version: 12
Test-runner (select one): jest

Device logs

12-17 00:01:06.220 19686 19765 I DetoxWSClient: Sending out action 'ready' (ID #-1000)
12-17 00:01:06.221 19686 19765 I DetoxDispatcher: Done with action 'isReady'
12-17 00:01:06.221 19686 19765 I DetoxDispatcher: Handling action 'loginSuccess' (ID #0)...
12-17 00:01:06.221 19686 19765 I DetoxDispatcher: Done with action 'loginSuccess'
12-17 00:01:06.221 19686 19765 I DetoxDispatcher: Handling action 'isReady' (ID #-1000)...
12-17 00:01:06.222 19686 19686 I Detox   : Wait is over: App is now idle!
12-17 00:01:06.222 19686 19765 I DetoxWSClient: Sending out action 'ready' (ID #-1000)
12-17 00:01:06.222 19686 19765 I DetoxDispatcher: Done with action 'isReady'
12-17 00:01:06.278  1543  2314 D ConnectivityService: NetReassign [no changes]
12-17 00:01:06.667 19686 19694 I ftware.template: Background concurrent copying GC freed 235840(11MB) AllocSpace objects, 22(94MB) LOS objects, 76% free, 7661KB/31MB, paused 120us,48us total 151.410ms
12-17 00:01:07.243 19686 19767 D DetoxWSClient: Received action 'invoke' (ID #1, params={"target":{"type":"Class","value":"com.wix.detox.espresso.EspressoDetox"},"method":"perform","args":[{"type":"Invocation","value":{"target":{"type":"Class","value":"androidx.test.espresso.Espresso"},"method":"onView","args":[{"type":"Invocation","value":{"target":{"type":"Class","value":"com.wix.detox.espresso.DetoxMatcher"},"method":"matcherForAtIndex","args":[{"type":"Integer","value":0},{"type":"Invocation","value":{"target":{"type":"Class","value":"com.wix.detox.espresso.DetoxMatcher"},"method":"matcherForTestId","args":["plus-icon"]}}]}}]}},{"type":"Invocation","value":{"target":{"type":"Class","value":"com.wix.detox.espresso.DetoxAction"},"method":"tapAtLocation","args":[{"type":"Integer","value":5},{"type":"Integer","value":10}]}}]})
12-17 00:01:07.243 19686 19765 I DetoxDispatcher: Handling action 'invoke' (ID #1)...
12-17 00:01:07.245 19686 19765 D Detox   : class com.wix.detox.espresso.DetoxMatcher, matcherForTestId, [plus-icon]
12-17 00:01:07.249 19686 19765 D Detox   : class com.wix.detox.espresso.DetoxMatcher, matcherForAtIndex, [0, (view.getTag() is "plus-icon" and view has effective visibility <VISIBLE>)]
12-17 00:01:07.251 19686 19765 D Detox   : class androidx.test.espresso.Espresso, onView, [View at index #0, of those matching MATCHER(view.getTag() is "plus-icon" and view has effective visibility <VISIBLE>)]
12-17 00:01:07.252 19686 19765 D Detox   : class com.wix.detox.espresso.DetoxAction, tapAtLocation, [5, 10]
12-17 00:01:07.254 19686 19765 D Detox   : class com.wix.detox.espresso.EspressoDetox, perform, [androidx.test.espresso.ViewInteraction@cc2fd4f, com.wix.detox.espresso.action.RNClickAction@24e1cdc]
12-17 00:01:07.272 19686 19686 I ViewInteraction: Performing 'com.wix.detox.espresso.action.detoxsingletap@e7a44ba click' action on view View at index #0, of those matching MATCHER(view.getTag() is "plus-icon" and view has effective visibility <VISIBLE>)
...
12-17 00:01:07.850 19686 19765 I DetoxWSClient: Sending out action 'invokeResult' (ID #1)
12-17 00:01:07.851 19686 19765 I DetoxDispatcher: Done with action 'invoke'
12-17 00:01:09.402  1543  2314 D ConnectivityService: NetReassign [no changes]

another tap() example

12-17 00:16:20.949 26520 26599 I DetoxWSClient: Sending out action 'invokeResult' (ID #3)
12-17 00:16:20.949 26520 26599 I DetoxDispatcher: Done with action 'invoke'
12-17 00:16:20.958 26520 26601 D DetoxWSClient: Received action 'invoke' (ID #4, params={"target":{"type":"Class","value":"com.wix.detox.espresso.EspressoDetox"},"method":"perform","args":[{"type":"Invocation","value":{"target":{"type":"Class","value":"androidx.test.espresso.Espresso"},"method":"onView","args":[{"type":"Invocation","value":{"target":{"type":"Class","value":"com.wix.detox.espresso.DetoxMatcher"},"method":"matcherForText","args":["Login"]}}]}},{"type":"Invocation","value":{"target":{"type":"Class","value":"com.wix.detox.espresso.DetoxViewActions"},"method":"click","args":[]}}]})
12-17 00:16:20.959 26520 26599 I DetoxDispatcher: Handling action 'invoke' (ID #4)...
12-17 00:16:20.959 26520 26599 D Detox   : class com.wix.detox.espresso.DetoxMatcher, matcherForText, [Login]
12-17 00:16:20.960 26520 26599 D Detox   : class androidx.test.espresso.Espresso, onView, [(an instance of android.widget.TextView and view.getText() with or without transformation to match: is "Login" and view has effective visibility <VISIBLE>)]
12-17 00:16:20.960 26520 26599 D Detox   : class com.wix.detox.espresso.DetoxViewActions, click, []
12-17 00:16:20.960 26520 26599 D Detox   : class com.wix.detox.espresso.EspressoDetox, perform, [androidx.test.espresso.ViewInteraction@a34ad82, com.wix.detox.espresso.action.RNClickAction@9d7ac93]

The text was updated successfully, but these errors were encountered:

AdamTyler · 2022-12-20T20:01:33Z

I'm also seeing this issue on Android API 33.
Detox will find the element and on calling tap, the button shows as though its held down. The logs all seem to show that the step fired the click/tap successfully but of course the next step will fail

Detox version: 20.1.0
React Native version: 0.70.6

12-20 13:51:32.072 10094 10259 I DetoxDispatcher: Handling action 'invoke' (ID #2)...
12-20 13:51:32.072 10094 10259 D Detox   : class com.wix.detox.espresso.DetoxMatcher, matcherForTestId, [onboarding-sign-up]
12-20 13:51:32.072 10094 10259 D Detox   : class androidx.test.espresso.Espresso, onView, [(view.getTag() is "onboarding-sign-up" and view has effective visibility <VISIBLE>)]
12-20 13:51:32.072 10094 10259 D Detox   : class com.wix.detox.espresso.DetoxViewActions, click, []
12-20 13:51:32.073 10094 10259 D Detox   : class com.wix.detox.espresso.EspressoDetox, perform, [androidx.test.espresso.ViewInteraction@578a4a3, com.wix.detox.espresso.action.RNClickAction@f99f3a0]
12-20 13:51:32.075 10094 10094 I ViewInteraction: Performing 'com.wix.detox.espresso.action.detoxsingletap@a87ab59 click' action on view (view.getTag() is "onboarding-sign-up" and view has effective visibility <VISIBLE>)
12-20 13:51:32.104 10094 10161 D EGL_emulation: app_time_stats: avg=514.85ms min=1.26ms max=3066.95ms count=6
12-20 13:51:32.601 10094 10259 I DetoxWSClient: Sending out action 'invokeResult' (ID #2)
12-20 13:51:32.602 10094 10259 I DetoxDispatcher: Done with action 'invoke'
12-20 13:51:32.608 10094 10261 D DetoxWSClient: Received action 'invoke' (ID #3, params={"target":{"type":"Class","value":"com.wix.detox.espresso.EspressoDetox"},"method":"perform","args":[{"type":"Invocation","value":{"target":{"type":"Class","value":"androidx.test.espresso.Espresso"},"method":"onView","args":[{"type":"Invocation","value":{"target":{"type":"Class","value":"com.wix.detox.espresso.DetoxMatcher"},"method":"matcherForTestId","args":["onboarding-phone"]}}]}},{"type":"Invocation","value":{"target":{"type":"Class","value":"com.wix.detox.espresso.DetoxViewActions"},"method":"click","args":[]}}]})
12-20 13:51:32.608 10094 10259 I DetoxDispatcher: Handling action 'invoke' (ID #3)...
12-20 13:51:32.608 10094 10259 D Detox   : class com.wix.detox.espresso.DetoxMatcher, matcherForTestId, [onboarding-phone]
12-20 13:51:32.608 10094 10259 D Detox   : class androidx.test.espresso.Espresso, onView, [(view.getTag() is "onboarding-phone" and view has effective visibility <VISIBLE>)]
12-20 13:51:32.608 10094 10259 D Detox   : class com.wix.detox.espresso.DetoxViewActions, click, []
12-20 13:51:32.609 10094 10259 D Detox   : class com.wix.detox.espresso.EspressoDetox, perform, [androidx.test.espresso.ViewInteraction@6cc051b, com.wix.detox.espresso.action.RNClickAction@c4e96b8]
12-20 13:51:32.618 10094 10259 I DetoxActionHandlers: Test exception

UPDATE: longPress does not have the same issue however multiTap does

sergtimosh · 2022-12-21T07:00:42Z

@AdamTyler Thanks for the confirmation. I was trying to find the way of how theoretically I can overcome this with other tap methods and longPress() can help, but not for every element. If the element is listening for longPress() it will act like longPress() was fired even with longPress(1) .

fossage · 2022-12-21T16:37:07Z

I am seeing the same issue across two different projects with:

Detox 19.2.6 + React Native 0.70.2
Detox 20.1.0 + React Native 0.69.1

d4vidi · 2023-01-11T10:12:52Z

@sergtimosh @AdamTyler @fossage We would very much appreciate a reproduction using DetoxTemplate so we could better inspect this. In essence, we've seen the various tap()'s working properly on recent Android versions.

programystic-dev · 2023-01-11T12:47:10Z

I can confirm I had the same issue. tap() and typeText() did not work for me.

Detox 20.1.1 + React Native 0.70.3

I was using emulator with API 33 - that was causing all the trouble.
Changed to API 31 - now everything works as expected.

sergtimosh · 2023-01-11T13:40:59Z

@d4vidi just checked with DetoxTemplate and API 33 system image and it's failing there too.

You can check the screencast below. I've just added 2s timeouts before and after tap() so it's clearly visible that element isn't released.
https://www.screencast.com/t/GGyBN9iBuNGs

FadiAboMsalam · 2023-01-15T10:16:56Z

I am seeing the same issue on Detox 20.1.1 + React Native 0.67.4

Also using API 31 on emulator made it work

d4vidi · 2023-01-16T14:29:50Z

I'm triaging, and will report ASAP.

d4vidi · 2023-01-16T14:45:04Z

I can approve this reproduces clearly with API v33. Presumably, something in Detox's tap-untap events injection fails to execute properly in a system running the recent API. Perhaps upgrading Espresso (3.4.0 -> 3.5.1) could fix this seamlessly (even though I didn't see anything related in their release notes); @sergtimosh would you be willing to try that?

sergtimosh · 2023-01-16T15:41:29Z

@d4vidi just tried to build my fork with Espresso upgraded to (3.5.1) and got build failure(the 3.4.0 builds fine). Anyway I don't feel enough competent to dig down into this.

> Task :detox:compileFullReleaseJavaWithJavac FAILED
/Users/serhiytymoshenko/work/proj/Detox/detox/android/detox/src/full/java/com/wix/detox/espresso/assertion/ViewAssertions.java:28: error: incompatible types: Object cannot be converted to Matcher<? super View>
        return new MatchesViewAssertion(checkNotNull(viewMatcher));
                                                    ^
Note: /Users/serhiytymoshenko/work/proj/Detox/detox/android/detox/src/full/java/com/wix/detox/Detox.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: Some messages have been simplified; recompile with -Xdiags:verbose to get full output
1 error

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':detox:compileFullReleaseJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

hkaras19 · 2023-01-21T20:26:21Z

@sergtimosh have you had any luck on this issue? I am running into the same problem. I can confirm that downgrading to 31 works for the emulator; however, I would like to run some of my tests on a physical android device that is running 32, and I am still seeing the tap holding.

sergtimosh · 2023-01-22T09:25:20Z

@hkaras19 no I had no luck with suggestion from @d4vidi.

d4vidi · 2023-01-29T22:20:18Z

@d4vidi just tried to build my fork with Espresso upgraded to (3.5.1) and got build failure(the 3.4.0 builds fine). Anyway I don't feel enough competent to dig down into this.

> Task :detox:compileFullReleaseJavaWithJavac FAILED
/Users/serhiytymoshenko/work/proj/Detox/detox/android/detox/src/full/java/com/wix/detox/espresso/assertion/ViewAssertions.java:28: error: incompatible types: Object cannot be converted to Matcher<? super View>
        return new MatchesViewAssertion(checkNotNull(viewMatcher));
                                                    ^
Note: /Users/serhiytymoshenko/work/proj/Detox/detox/android/detox/src/full/java/com/wix/detox/Detox.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: Some messages have been simplified; recompile with -Xdiags:verbose to get full output
1 error

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':detox:compileFullReleaseJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

Apparently Espresso 3.5.1 comes with some API changes / deprecations removal. I doubt we would be able to get into this in the near future - would appreciate a more thorough attempt.

d4vidi · 2023-02-22T16:27:25Z

We are likely to address this within the upcoming 1-2 months.

Rednegniw · 2023-09-26T14:40:30Z

Hello, thank you for maintaining Detox, it's a great library.

Unfortunately, experiencing this as well on API 33. Is there any news on this?

aaronpliu · 2023-09-28T06:14:05Z

Blocking android on

API 34
Detox 20.12.0
RN 0.71.4

AnisDerbel · 2023-10-03T09:33:05Z

I have same on

Android 33
Detox 20.9.1
React native 0.72.0

This is very crucial bug!

jeroen-van-dijk · 2023-10-03T13:02:58Z

Also facing this issue. longPress() does work as a workaround, however I need tap({x:5, y:10}) with coordinates which I cannot do with longPress().

Any idea what might be causes the issue with the Android sdk? It seems like espresso is not up-to-date? Maybe updating espresso-core to 3.5.1 solves some issues?

ericschaal · 2023-10-11T21:32:05Z

As pointed out by d4vid, the root cause seems to be linked to the custom DetoxMultiTap implementation. I've found a temporary solution by using the standard espresso Tap.SINGLE instead of DetoxMultiTap. Please refer to the attached patch file for details.

However, this approach does have its drawbacks. As discussed in DetoxMultiTap, this change introduces some timing inconsistencies, particularly taps being misinterpreted as long taps. For my specific application, which doesn't utilize long tap handlers, the Tap.SINGLE solution is satisfactory for now.

I intend to delve deeper into the DetoxMultiTap issues and try to resolve them when I can. However, I'm quite pressed for time at the moment. It would be greatly appreciated if someone else could also investigate this in the interim.

diff --git a/node_modules/detox/android/detox/src/full/java/com/wix/detox/espresso/action/RNClickAction.java b/node_modules/detox/android/detox/src/full/java/com/wix/detox/espresso/action/RNClickAction.java
index 68bf039..8a617f9 100644
--- a/node_modules/detox/android/detox/src/full/java/com/wix/detox/espresso/action/RNClickAction.java
+++ b/node_modules/detox/android/detox/src/full/java/com/wix/detox/espresso/action/RNClickAction.java
@@ -14,6 +14,7 @@ import androidx.test.espresso.action.CoordinatesProvider;
 import androidx.test.espresso.action.GeneralClickAction;
 import androidx.test.espresso.action.GeneralLocation;
 import androidx.test.espresso.action.Press;
+import androidx.test.espresso.action.Tap;
 
 import static androidx.test.espresso.matcher.ViewMatchers.isDisplayingAtLeast;
 
@@ -22,7 +23,7 @@ public class RNClickAction implements ViewAction {
 
     public RNClickAction() {
         clickAction = new GeneralClickAction(
-                        new DetoxSingleTap(),
+                        Tap.SINGLE,
                         GeneralLocation.VISIBLE_CENTER,
                         Press.FINGER,
                         InputDevice.SOURCE_UNKNOWN,
@@ -31,7 +32,7 @@ public class RNClickAction implements ViewAction {
 
     public RNClickAction(CoordinatesProvider coordinatesProvider) {
         clickAction = new GeneralClickAction(
-                        new DetoxSingleTap(),
+                        Tap.SINGLE,
                         coordinatesProvider,
                         Press.FINGER,
                         InputDevice.SOURCE_UNKNOWN,

(Tested on Android 34)

ericschaal · 2023-10-12T14:22:14Z

This patch seems to fix the issue. I updated obtainUpEvent in com.wix.detox.espresso.action.common.MotionEvent to match more closely the implementation of obtainUpEvent in androidx.test.espresso.action.MotionEvents.

Can someone confirm?
Patch should be easy to apply on Detox 20.13.0 with patch-package

Patch

diff --git a/node_modules/detox/android/detox/src/main/java/com/wix/detox/espresso/action/common/MotionEvents.kt b/node_modules/detox/android/detox/src/main/java/com/wix/detox/espresso/action/common/MotionEvents.kt
index 1a8e1d7..48b9233 100644
--- a/node_modules/detox/android/detox/src/main/java/com/wix/detox/espresso/action/common/MotionEvents.kt
+++ b/node_modules/detox/android/detox/src/main/java/com/wix/detox/espresso/action/common/MotionEvents.kt
@@ -13,7 +13,7 @@ class MotionEvents {
             = MotionEvents.obtainMovement(downEvent.downTime, eventTime, floatArrayOf(x, y))!!
 
     fun obtainDownEvent(x: Float, y: Float, precision: FloatArray = PRECISION)
-        = obtainDownEvent(x, y, precision, null)
+            = obtainDownEvent(x, y, precision, null)
 
     fun obtainDownEvent(x: Float, y: Float, precision: FloatArray = PRECISION, _downTime: Long?): MotionEvent {
         val pointerProperties = MotionEvent.PointerProperties().apply {
@@ -30,24 +30,51 @@ class MotionEvents {
         val downTime = _downTime ?: SystemClock.uptimeMillis()
 
         return MotionEvent.obtain(
-                downTime,
-                downTime,
-                MotionEvent.ACTION_DOWN,
-                1,
-                arrayOf(pointerProperties),
-                arrayOf(pointerCoords),
-                0,
-                MotionEvent.BUTTON_PRIMARY,
-                precision[0],
-                precision[1],
-                0,
-                0,
-                InputDevice.SOURCE_UNKNOWN,
-                0)
+            downTime,
+            downTime,
+            MotionEvent.ACTION_DOWN,
+            1,
+            arrayOf(pointerProperties),
+            arrayOf(pointerCoords),
+            0,
+            MotionEvent.BUTTON_PRIMARY,
+            precision[0],
+            precision[1],
+            0,
+            0,
+            InputDevice.SOURCE_UNKNOWN,
+            0)
     }
 
-    fun obtainUpEvent(downEvent: MotionEvent, eventTime: Long, x: Float, y: Float): MotionEvent
-            = MotionEvent.obtain(downEvent.downTime, eventTime, MotionEvent.ACTION_UP, x, y, 0)!!
+    fun obtainUpEvent(downEvent: MotionEvent, eventTime: Long, x: Float, y: Float): MotionEvent {
+        val pointerProperties = MotionEvent.PointerProperties().apply {
+            id = 0
+            toolType = MotionEvent.TOOL_TYPE_UNKNOWN
+        }
+        val pointerCoords = MotionEvent.PointerCoords().apply {
+            clear()
+            this.x = x
+            this.y = y
+            this.pressure = 0f
+            this.size = 1f
+        }
+        return MotionEvent.obtain(
+            downEvent.downTime,
+            eventTime,
+            MotionEvent.ACTION_UP,
+            1, // pointerCounts
+            arrayOf(pointerProperties),
+            arrayOf(pointerCoords),
+            0, // metaState
+            downEvent.buttonState,
+            downEvent.xPrecision,
+            downEvent.yPrecision,
+            0, // deviceId
+            0, // edgeFlags
+            downEvent.source,
+            0
+        )
+    }
 
     fun sendDownAsync(uiController: UiController, x: Float, y: Float, precision: FloatArray = PRECISION): MotionEvent {
         val downEvent = obtainDownEvent(x, y, precision, null)

noomorph · 2023-10-13T07:54:09Z

@ericschaal (🏆 thanks for your patch), @gomesbreno, @sdurandeu, @mostafaberg, @AdamTyler, @isilher, @otech47, @markpar, @sunchanras, @fossage, @catanet, @d4vidi, @jeroen-van-dijk, @BBKolton, @AnisDerbel, @cortisiko, @FadiAboMsalam, @Rednegniw, @programystic-dev, @ShivamJoker, @dooleyb1, @cpham-groundswell, @sergtimosh, @arthwood, @zwerg44, @andac-ozcan, @otoniel-isidoro, @manuquentin, @codexico, @nateshmbhat, @vjdhanota, @raldred.

The patched version is available as detox@20.13.1-smoke.0 on NPM.

Could you please verify if the fix works and if there are any undesirable side effects?
We'll release the fix next Thursday if no negative feedback (e.g. regressions, etc.) is received.

mostafaberg · 2023-10-13T07:56:16Z

Could you please verify if the fix works and if there are any undesirable side effects?

We'll release the fix next Thursday if no negative feedback (e.g. regressions, etc.) is received.

I'll give that a quick test on Monday morning and report back 👌 great work !

markpar · 2023-10-13T20:33:50Z

I tried it out and this issue is fixed for my tests and app. However, I'm now running into #2787. 😆

jeroen-van-dijk · 2023-10-16T10:14:20Z

@noomorph Thanks for the support! We tested the patched version and it solved our issues! 🚀

noomorph · 2023-10-16T11:54:04Z

Thanks for the feedback.
In the meantime, we don't see any breakages on our Android tests + older APIs, so I'll likely release it sooner.
Let's plan that for tomorrow.

mostafaberg · 2023-10-16T12:20:26Z

This unfortunately does not seem to resolve things fully, might cause some confusion, as @markpar mentioned, the swiping does not work.

In our case, we have a global scroller that handles all SectionList, Flatlist & Scrollview components, while looking for a component within any of those, we'll automatically scroll until found.

this behavior is pretty much what makes/breaks the tests since lots of components are outside the screen during e2e tests.

it does fix the tapping though, which is a plus, but I'm not sure if that's ideal 🤔

markpar · 2023-10-16T22:48:03Z

~~In my case, adding flex: 1 to the parent container, as described in #2787 (comment) got me past the issue.~~

Disregard that comment. I was using an Android 11 phone and I thought I was on Android 13. 🤦

noomorph · 2023-10-17T08:22:54Z

@mostafaberg AFAIU, tapping handlers and scrolling handlers are separate pieces of code, so I don't think we should wait for the scrolling fixes to release @ericschaal's patch.

If anyone has time soon to play with the scrolling code and see what changes can fix it, you are welcome – Use patch-package or anything that works for you, test your fix, and if you're sure it works, I'll be available to assist you with beta testing, as we did with @ericschaal last week.

mostafaberg · 2023-10-17T08:25:40Z

@mostafaberg AFAIU, tapping handlers and scrolling handlers are separate pieces of code, so I don't think we should wait for the scrolling fixes to release @ericschaal's patch.

If anyone has time soon to play with the scrolling code and see what changes can fix it, you are welcome – Use patch-package or anything that works for you, test your fix, and if you're sure it works, I'll be available to assist you with beta testing, as we did with @ericschaal last week.

You're 100% correct this does fix the tapping issue at least!, maybe leave a small "known issue" note in the release notes to avoid more tickets coming in later 😄

noomorph · 2023-10-17T08:30:44Z

Okay, sure, I'll add that to release note. Thanks for the suggestion!

Overall, I'd be glad to help further with Android 31+ bugs, and maybe eventually I'll do if my team continues to be unavailable for a long time, but as you can see sometimes these fixes are just ±10 lines of code, so I encourage everyone who's comfortable enough with Android to look into it. 🙏 Pull requests from the community remain our top 1 priority, I can assure you'll get reviews and assistance quickly.

mostafaberg · 2023-10-17T09:13:19Z

Will try to get more time to get this done, my initial approach was to upgrade espresso but I didn't get enough time as it was a bigger change than I could manage at the time :( , might as well find some smaller changes as you recommended and get things rolling 👍

noomorph · 2023-10-17T11:07:21Z

✅ The fix is available in detox@20.13.1.

patriksletmo · 2023-10-17T14:04:00Z

I was able to get scrolling working with an almost identical patch to what @ericschaal provided.

Unfortunately, swiping is still not working. It might be fixable by implementing a custom swiper instead of relying on the built-in implementations Swipe.FAST and Swipe.SLOW, in case anyone wants to give that a shot.

Patch

diff --git a/node_modules/detox/android/detox/src/main/java/com/wix/detox/espresso/action/common/MotionEvents.kt b/node_modules/detox/android/detox/src/main/java/com/wix/detox/espresso/action/common/MotionEvents.kt
index d8fc451..502ad40 100644
--- a/node_modules/detox/android/detox/src/main/java/com/wix/detox/espresso/action/common/MotionEvents.kt
+++ b/node_modules/detox/android/detox/src/main/java/com/wix/detox/espresso/action/common/MotionEvents.kt
@@ -9,8 +9,37 @@ import androidx.test.espresso.action.MotionEvents
 private val PRECISION = floatArrayOf(16f, 16f)
 
 class MotionEvents {
-    fun obtainMoveEvent(downEvent: MotionEvent, eventTime: Long, x: Float, y: Float): MotionEvent
-            = MotionEvents.obtainMovement(downEvent.downTime, eventTime, floatArrayOf(x, y))!!
+    fun obtainMoveEvent(downEvent: MotionEvent, eventTime: Long, x: Float, y: Float): MotionEvent {
+        val pointerProperties = MotionEvent.PointerProperties().apply {
+            clear()
+            id = 0
+            toolType = MotionEvent.TOOL_TYPE_UNKNOWN
+        }
+        val pointerCoords = MotionEvent.PointerCoords().apply {
+            clear()
+            this.x = x
+            this.y = y
+            this.pressure = 0f
+            this.size = 1f
+        }
+
+        return MotionEvent.obtain(
+              downEvent.downTime,
+              eventTime,
+              MotionEvent.ACTION_MOVE,
+              1, // pointerCounts
+              arrayOf(pointerProperties),
+              arrayOf(pointerCoords),
+              0, // metaState
+              downEvent.buttonState,
+              downEvent.xPrecision,
+              downEvent.yPrecision,
+              0, // deviceId
+              0, // edgeFlags
+              downEvent.source,
+              0
+        )
+    }
 
     fun obtainDownEvent(x: Float, y: Float, precision: FloatArray = PRECISION)
         = obtainDownEvent(x, y, precision, null)

* feat: generate psk when creating community; add psk connection protector to libp2p * feat: add base64 encoded psk to invitation link * chore: refactor invitation url parsing functions * test: temporarily skip backward compatibility e2e test - psk changes are not backward compatible * chore: update detox version - fixes 'tap' wix/Detox#3762 * chore: increase timeout for multiple clients e2e test

## **Description** The purpose of this PR is to accomplish two things: bump detox version (this hasn't been done in a couple of months) Implement dynamic scroll in tests Previously, the use of APIs higher than 30 was hindered by an Android blocker on Detox's end. As mentioned in #6384 > There is currently an issue when running detox on android 12 and 13 (API 32/33) which prevents the tests from running. The issue is, the tap() action is treated like a tapAndHold() action. See the open issue in wix/detox wix/Detox#3762 With this new detox version bump, the blocker has been lifted, allowing us to utilize Android 31+. Furthermore, how we scroll to elements introduces flakiness. Instead of hardcoding a scroll speed in tests, we will now introduce dynamic scrolling. We will scroll on a view until the element is visible within the viewport. This was done using [whileElement](https://wix.github.io/Detox/docs/api/actions/#whileelementelement) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After** Smoke run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/42936d4e-1df8-40ca-bd88-4f408cdd655a Regression Run: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/cb83ae29-a0a4-49f5-a2f5-7c6683bf38e3 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Chris Wilcox <chris.wilcox@consensys.net>

sergtimosh added platform: android status: triage type: bug 🐞 labels Dec 16, 2022

d4vidi assigned jonathanmos Jan 11, 2023

hkaras19 mentioned this issue Jan 19, 2023

Android won't unpress button #3857

Closed

2 tasks

d4vidi added user: looking for contributors status: accepted and removed status: triage labels Jan 29, 2023

wix deleted a comment from github-actions bot Jan 29, 2023

AloeareV mentioned this issue Feb 14, 2023

Detoxtests zingolabs/zingo-mobile#180

Merged

This was referenced Feb 22, 2023

Detox not support to android version 33. #3945

Closed

unable to build android with react native 0.71.1, got error android:exported needs to be explicitly specified for element #3867

Closed

d4vidi changed the title ~~.tap() acts like tap+hold on Android 12, 13 with API 32 and API 33~~ Android API 32, 33 (v12): .tap() acts like tap+hold Feb 23, 2023

d4vidi unassigned jonathanmos Feb 23, 2023

d4vidi pinned this issue Feb 23, 2023

d4vidi mentioned this issue Feb 23, 2023

.tap() function doesn't trigger onClick() properties of react components on Android Tiramisu #3879

Closed

2 tasks

asafkorem self-assigned this Sep 26, 2023

This was referenced Oct 12, 2023

fix(android): tap event on android API>31 #4216

Merged

typeText do not work no android on react native 0.72.5 #4206

Open

noomorph closed this as completed Oct 17, 2023

EmiM added a commit to TryQuiet/quiet that referenced this issue Oct 26, 2023

chore: update detox version - fixes 'tap' wix/Detox#3762

967210e

aaronpliu mentioned this issue Oct 30, 2023

Android API 33 (v13) / API 34 (v14) tap fail #4257

Closed

2 tasks

Seraphiyra mentioned this issue Nov 7, 2023

Android tap, swipe, scroll, and scrollTo do not work #4240

Open

2 tasks

d4vidi unpinned this issue Nov 12, 2023

cortisiko mentioned this issue Dec 20, 2023

test: bump detox + implement dynamic scroll in e2e tests MetaMask/metamask-mobile#8174

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android API 32, 33 (v12): .tap() acts like tap+hold #3762

Android API 32, 33 (v12): .tap() acts like tap+hold #3762

sergtimosh commented Dec 16, 2022 •

edited

Loading

AdamTyler commented Dec 20, 2022 •

edited

Loading

sergtimosh commented Dec 21, 2022 •

edited

Loading

fossage commented Dec 21, 2022 •

edited

Loading

d4vidi commented Jan 11, 2023

programystic-dev commented Jan 11, 2023

sergtimosh commented Jan 11, 2023

FadiAboMsalam commented Jan 15, 2023

d4vidi commented Jan 16, 2023

d4vidi commented Jan 16, 2023

sergtimosh commented Jan 16, 2023

hkaras19 commented Jan 21, 2023

sergtimosh commented Jan 22, 2023

d4vidi commented Jan 29, 2023 •

edited

Loading

d4vidi commented Feb 22, 2023

Rednegniw commented Sep 26, 2023

aaronpliu commented Sep 28, 2023

AnisDerbel commented Oct 3, 2023

jeroen-van-dijk commented Oct 3, 2023

ericschaal commented Oct 11, 2023 •

edited

Loading

ericschaal commented Oct 12, 2023 •

edited

Loading

noomorph commented Oct 13, 2023 •

edited

Loading

mostafaberg commented Oct 13, 2023

markpar commented Oct 13, 2023

jeroen-van-dijk commented Oct 16, 2023 •

edited

Loading

noomorph commented Oct 16, 2023

mostafaberg commented Oct 16, 2023

markpar commented Oct 16, 2023 •

edited

Loading

noomorph commented Oct 17, 2023

mostafaberg commented Oct 17, 2023

noomorph commented Oct 17, 2023

mostafaberg commented Oct 17, 2023

noomorph commented Oct 17, 2023

patriksletmo commented Oct 17, 2023

Android API 32, 33 (v12): .tap() acts like tap+hold #3762

Android API 32, 33 (v12): .tap() acts like tap+hold #3762

Comments

sergtimosh commented Dec 16, 2022 • edited Loading

What happened?

What was the expected behaviour?

Was it tested on latest Detox?

Did your test throw out a timeout?

Help us reproduce this issue!

In what environment did this happen?

Device logs

AdamTyler commented Dec 20, 2022 • edited Loading

sergtimosh commented Dec 21, 2022 • edited Loading

fossage commented Dec 21, 2022 • edited Loading

d4vidi commented Jan 11, 2023

programystic-dev commented Jan 11, 2023

sergtimosh commented Jan 11, 2023

FadiAboMsalam commented Jan 15, 2023

d4vidi commented Jan 16, 2023

d4vidi commented Jan 16, 2023

sergtimosh commented Jan 16, 2023

hkaras19 commented Jan 21, 2023

sergtimosh commented Jan 22, 2023

d4vidi commented Jan 29, 2023 • edited Loading

d4vidi commented Feb 22, 2023

Rednegniw commented Sep 26, 2023

aaronpliu commented Sep 28, 2023

AnisDerbel commented Oct 3, 2023

jeroen-van-dijk commented Oct 3, 2023

ericschaal commented Oct 11, 2023 • edited Loading

ericschaal commented Oct 12, 2023 • edited Loading

noomorph commented Oct 13, 2023 • edited Loading

mostafaberg commented Oct 13, 2023

markpar commented Oct 13, 2023

jeroen-van-dijk commented Oct 16, 2023 • edited Loading

noomorph commented Oct 16, 2023

mostafaberg commented Oct 16, 2023

markpar commented Oct 16, 2023 • edited Loading

noomorph commented Oct 17, 2023

mostafaberg commented Oct 17, 2023

noomorph commented Oct 17, 2023

mostafaberg commented Oct 17, 2023

noomorph commented Oct 17, 2023

patriksletmo commented Oct 17, 2023

sergtimosh commented Dec 16, 2022 •

edited

Loading

AdamTyler commented Dec 20, 2022 •

edited

Loading

sergtimosh commented Dec 21, 2022 •

edited

Loading

fossage commented Dec 21, 2022 •

edited

Loading

d4vidi commented Jan 29, 2023 •

edited

Loading

ericschaal commented Oct 11, 2023 •

edited

Loading

ericschaal commented Oct 12, 2023 •

edited

Loading

noomorph commented Oct 13, 2023 •

edited

Loading

jeroen-van-dijk commented Oct 16, 2023 •

edited

Loading

markpar commented Oct 16, 2023 •

edited

Loading