Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tone down tap gesture on Android #1902

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Tone down tap gesture on Android #1902

merged 1 commit into from
Feb 12, 2020

Conversation

d4vidi
Copy link
Collaborator

@d4vidi d4vidi commented Feb 12, 2020

  • This is a small change
  • This change has been discussed in issue #0 and the solution has been agreed upon with maintainers.

Description:
In the context of issues such as software-mansion/react-native-reanimated#596, we find that the current implementation of Detox' single-tap - though optimal, can be a bit too rough. We therefore need to unwillingly tone it down a bit, in the very least, until that bug is fixed.

@d4vidi d4vidi self-assigned this Feb 12, 2020
@d4vidi d4vidi merged commit 397bd22 into master Feb 12, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 15, 2020
@LeoNatan LeoNatan deleted the ease-android-singletap branch March 11, 2020 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant