fix(android): extract material slider value attribute with reflection. #4203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #2846 |
1 task
This fixes a `ClassNotFoundException` error that is thrown when the Slider class from the `com.google.android.material.slider` package is not found at runtime. The solution is to use reflection instead of importing the Slider class, which may not necessarily exist in the app. Also, I made a light refactoring for get-attributes related code.
asafkorem
force-pushed
the
slider-get-attributes
branch
from
b6ccd55
to
4401837
Compare
asafkorem
commented
Sep 27, 2023
detox/android/detox/src/full/java/com/wix/detox/espresso/action/GetAttributesAction.kt
Outdated
Show resolved
Hide resolved
detox/android/detox/src/full/java/com/wix/detox/espresso/action/GetAttributesAction.kt
Outdated
Show resolved
Hide resolved
detox/android/detox/src/full/java/com/wix/detox/espresso/action/GetAttributesAction.kt
Outdated
Show resolved
Hide resolved
asafkorem
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a
ClassNotFoundExceptionerror that is thrown when the Slider class from thecom.google.android.material.sliderpackage is not found at runtime.The solution is to use reflection instead of importing the Slider class, which may not necessarily exist in the app.
Also, I made a light refactoring for get-attributes related code.