fix(Android): Scrolling inaccuracy and exception while overscrolling #4482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4vidi
reviewed
May 6, 2024
detox/android/detox/src/main/java/com/wix/detox/espresso/scroll/ScrollHelper.java
Show resolved
Hide resolved
gosha212
changed the title
asafkorem
approved these changes
May 6, 2024
asafkorem
deleted the
feat/712-internal-case-342-scroll-on-android-doesnt-work-as-expected-on-long-screens-it-keeps-scrolling-too-much
branch
|
Released with Detox 20.21.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, I have fixed an inaccuracy of scrolling in Android which caused screenshot tests to fail. Every time a tests was executed the scrolling was missing the destination in a few pixels in non deterministic way.