fix unwrap to not fail when using _.prototype.commit()

wix-incubator · Sep 16, 2015 · ff1ee24 · ff1ee24
1 parent 4d0b29e
commit ff1ee24
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/lib/rules/unwrap.js b/lib/rules/unwrap.js
@@ -13,13 +13,9 @@ module.exports = function (context) {
     return {
         CallExpression: function (node) {
             if (lodashUtil.isEndOfChain(node) &&
-                (lodashUtil.isChainable(node) || (lodashUtil.isExplicitMethodChaining(node) && !lodashUtil.isChainBreaker(node)))) {
+                ((lodashUtil.isChainable(node) && !lodashUtil.isCallToMethod(node, 'commit')) || (lodashUtil.isExplicitMethodChaining(node) && !lodashUtil.isChainBreaker(node)))) {
                 context.report(node, 'Missing unwrapping at end of chain');
             }
         }
     };
 };
-
-module.exports.schema = [
-    // JSON Schema for rule options goes here
-];
diff --git a/tests/lib/rules/unwrap.js b/tests/lib/rules/unwrap.js
@@ -20,6 +20,8 @@ ruleTester.run('unwrap', rule, {
         code: 'var x = _(a).map(f).filter(g).value()'
     }, {
         code: 'var x = _.chain(a).map(f).value()'
+    }, {
+        code: 'var stillWrapped = _(a).forEach(f).commit();'
     }],
     invalid: [{
         code: 'var x = _(a).map(f);',