Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(language-service): filter out false diagnostics for st-scope selectors with special characters #2531

Merged
merged 2 commits into from
May 29, 2022
Merged

fix(language-service): filter out false diagnostics for st-scope selectors with special characters #2531

merged 2 commits into from
May 29, 2022

Conversation

tomrav
Copy link
Collaborator

@tomrav tomrav commented May 23, 2022

Resolves #2200

@tomrav tomrav self-assigned this May 23, 2022
@tomrav tomrav added bug Unexpected behavior or exception diagnostics Warnings and errors language-service Completions, highlights, definitions and more LSP capabilities labels May 23, 2022
@tomrav tomrav requested review from idoros and barak007 May 23, 2022 13:39
@tomrav tomrav merged commit 596803e into master May 29, 2022
@tomrav tomrav deleted the tom/fix-lsp-stscope-css-diagnostics branch May 29, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barak007 barak007 barak007 left review comments

@idoros idoros idoros approved these changes

Assignees

@tomrav tomrav

Labels
bug Unexpected behavior or exception diagnostics Warnings and errors language-service Completions, highlights, definitions and more LSP capabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LSP issues false diagnostic about @stScope params containing special charactars (:, [], *...)
3 participants
@tomrav @idoros @barak007