-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): transition from native @namespace
(conflict)
#2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoros
added
feature
New syntax feature or behavior
core
Processing and transforming logic
tech debt
Updates, upgrades, stale code and work-arounds
labels
Jul 20, 2022
idoros
changed the title
feat(core): attempt to avoid native
feat(core): transition from native Jul 23, 2022
@namespace
conflict@namespace
(conflict)
barak007
reviewed
Aug 1, 2022
barak007
reviewed
Aug 1, 2022
barak007
requested changes
Aug 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
final stuff
idoros
force-pushed
the
ido/stylable-namespace-atrule
branch
from
August 2, 2022 07:28
b5cdfb2
to
51c38ad
Compare
- all except escapes - no diagnostics for `@namespace`
- replace `@namespace` with `@st-namespace` - suppress `unknown at-rule` diagnostic
idoros
force-pushed
the
ido/stylable-namespace-atrule
branch
from
August 2, 2022 07:40
51c38ad
to
ff8ba26
Compare
barak007
approved these changes
Aug 3, 2022
This was referenced Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an alternative to
@namespace
in order to remove conflict with native CSS.Tasks
st-namespace
feature@st-namespace
atrule@st-namespace "dropdown";
@st-namespace 'dropdown';
@st-namespace "group-card";
@st-namespace "MixCapitalization";
@st-namespace "http://www.w3.org/1999/xhtml";
<- collect just ident-like@st-namespace prefix "http://www.site.com/foo";
<- no prefix@st-namespace url(https://www.site.com);
<- no url@namespace
for backward compatibility (just when matches validation)@namespace
only if a namespace was generated from it@st-namespace
@st-namespace
instead and add it as a known at-rule@namespace
to@st-namespace
code mod@namespace
- v4 #2641@st-namespace
only (maybe a small section about previous behavior)@namespace
in the next major