Make engine skip planning if there are any downgrade related bundles #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rseanhall
force-pushed
the
engine-downgrade
branch
from
801784a
to
8390a85
Compare
rseanhall
commented
Mar 14, 2022
Comment on lines
+1361
to
+1362
| if (BOOTSTRAPPER_RELATED_BUNDLE_PLAN_TYPE_DOWNGRADE == pRelatedBundle->planRelationType && | ||
| pRelatedBundle->fPlannable && !fUninstalling && BOOTSTRAPPER_RELATION_UPGRADE != relationType) |
There was a problem hiding this comment.
I wasn't sure which way to go here. If the related bundle isn't plannable (registered in ARP, but missing from the package cache so it can't be run), should it block the current bundle from downgrading it?
Comment on lines
+1075
to
+1078
| if (m_fSuppressDowngradeFailure) | ||
| { | ||
| *phrStatus = S_OK; | ||
| } |
There was a problem hiding this comment.
I wonder if this should be a feature in the engine instead of wixstdba.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wixtoolset/issues#6677
Fixes wixtoolset/issues#6722
Reverts wixtoolset/issues#6537