WIXBUG:4589 #195

Merged
merged 1 commit into from Jan 31, 2015

Projects

None yet

3 participants

@barnson
Member
barnson commented Jan 31, 2015

Catch exceptions from Version when passing in arbitrary strings. For bundles, try to recover a three-part version number.

@barnson barnson WIXBUG:4589 - Catch exceptions from Version when passing in arbitrary…
… strings. For bundles, try to recover a three-part version number.
9d25a3e
@robmen robmen merged commit f72de47 into wixtoolset:develop Jan 31, 2015
@rseanhall rseanhall commented on the diff Jan 31, 2015
src/tools/wix/ChainPackageInfo.cs
@@ -611,7 +611,23 @@ private void ResolveMsiPackage(BinderFileManager fileManager, Dictionary<string,
if (!Common.IsValidModuleOrBundleVersion(this.Version))
{
- this.core.OnMessage(WixErrors.InvalidProductVersion(this.PackagePayload.SourceLineNumbers, this.Version, sourcePath));
+ // not a proper .NET version (i.e., five fields); can we get a valid three-part version number?
@rseanhall
rseanhall Jan 31, 2015 Member

Can we try to get a four-part version number before falling back to three? Burn does use the fourth part.

@barnson
barnson Feb 1, 2015 Member

I think we have the technology for that...but the bug says three. Why does the bug say three? We should fire the scribe. I can't think of a reason not to take all four parts except that major upgrades aren't going to work either way...

@rseanhall
rseanhall Feb 1, 2015 Member

I don't follow your comment about major upgrades. Burn will consider 1.0.0.0 to 1.0.0.1 a major upgrade assuming a standard Upgrade table.

@barnson barnson deleted the barnson:bug4589.0 branch May 8, 2015
@barnson barnson restored the barnson:bug4589.0 branch Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment