WIXBUG:4589 #195
Merged
WIXBUG:4589 #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… strings. For bundles, try to recover a three-part version number.
| @@ -611,7 +611,23 @@ private void ResolveMsiPackage(BinderFileManager fileManager, Dictionary<string, | |||
|
|
|||
| if (!Common.IsValidModuleOrBundleVersion(this.Version)) | |||
| { | |||
| this.core.OnMessage(WixErrors.InvalidProductVersion(this.PackagePayload.SourceLineNumbers, this.Version, sourcePath)); | |||
| // not a proper .NET version (i.e., five fields); can we get a valid three-part version number? | |||
There was a problem hiding this comment.
Can we try to get a four-part version number before falling back to three? Burn does use the fourth part.
There was a problem hiding this comment.
I think we have the technology for that...but the bug says three. Why does the bug say three? We should fire the scribe. I can't think of a reason not to take all four parts except that major upgrades aren't going to work either way...
There was a problem hiding this comment.
I don't follow your comment about major upgrades. Burn will consider 1.0.0.0 to 1.0.0.1 a major upgrade assuming a standard Upgrade table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch exceptions from Version when passing in arbitrary strings. For bundles, try to recover a three-part version number.