Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version includes build output for macOS #22

Closed
ghost opened this issue Sep 28, 2016 · 10 comments
Closed

Latest version includes build output for macOS #22

ghost opened this issue Sep 28, 2016 · 10 comments

Comments

@ghost
Copy link

ghost commented Sep 28, 2016

Commit c0ee940 updated TBB to 2017, but also includes build output for macOS, which I assume was added accidentally. That should be removed (although ideally from the history completely).

@wjakob
Copy link
Owner

wjakob commented Sep 28, 2016

Can you be more specific? Which files are the build output? I remember checking and not seeing anything objectionable.

@ghost
Copy link
Author

ghost commented Sep 28, 2016

@wjakob
Copy link
Owner

wjakob commented Sep 28, 2016

argh :-S. That is indeed a problem! I will have to rewrite history to get rid of this.

cc @hjmjohnson

@ghost
Copy link
Author

ghost commented Sep 28, 2016

@wjakob Yeah, I had mentioned that problem in #17 (comment)

@wjakob
Copy link
Owner

wjakob commented Sep 28, 2016

Sorry, I did not spot them before merging and assumed that @hjmjohnson removed them.

@ghost
Copy link
Author

ghost commented Sep 28, 2016

No problem! Thanks for your help! 👍

@hjmjohnson
Copy link
Contributor

I am sorry. I did remove them at least 1 time, but a subsequent update must have re-introduced them.

What can I do to help resolve this issue?

Hans

@wjakob
Copy link
Owner

wjakob commented Sep 28, 2016

History is rewritten.

@wjakob wjakob closed this as completed Sep 28, 2016
@ghost
Copy link
Author

ghost commented Sep 28, 2016

Awesome. Thanks!

@hjmjohnson
Copy link
Contributor

@wjakob @LogicalKnight
THANK YOU!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants