Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing skips for external access. #161

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Add missing skips for external access. #161

merged 1 commit into from
Mar 28, 2022

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Feb 6, 2021

You can test this by running unshare -n -r -- go test -short ./...

@QuLogic
Copy link
Contributor Author

QuLogic commented Feb 6, 2021

Hmm, TestCacheIntegration also needs the skip, though for some reason it didn't fail with unshare. Not sure if it caches on disk and maybe that needs to be cleared to reproduce.

@wjdp wjdp merged commit 7fd8514 into wjdp:master Mar 28, 2022
@wjdp
Copy link
Owner

wjdp commented Mar 28, 2022 •
edited
Loading

@QuLogic Thank you for this, sorry for the late action

@QuLogic QuLogic deleted the skip-external branch March 28, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuLogic @wjdp