Put version string in __init__.py #214
Conversation
wkentaro
force-pushed
the
put_version_in_init_py
branch
2 times, most recently
from
84290fb
to
97fa1cc
Compare
setup.py
Outdated
| long_description=get_long_description(), | ||
| long_description_content_type="text/markdown", | ||
| author="Kentaro Wada", | ||
| author_email="www.kentaro.wada@gmail.com", |
There was a problem hiding this comment.
Is this actually the email you wan to put here?
You have www. as a prefix?
There was a problem hiding this comment.
yes, because my name is very common in Japan :)
There was a problem hiding this comment.
It is a very unique name to me 🤠
setup.py
Outdated
| sys.exit(1) | ||
|
|
||
| commands = [ | ||
| "git pull origin main", |
There was a problem hiding this comment.
This seems to be a local first release process.
- Clone locally.
- Change the version constant.
- Run the setup script.
It can get very tiresome to change that constant locally, but it does help in the sense that when you download the code without git, you can see the version in the source.
Personally I would put these in a separate release script (calling bash from python is tiring to debug).
Other release process would be more github first, where things are triggered solely on the basis of tags.
Ultimately, not using pkg_resources is what I care about, this seems to address that
wkentaro
force-pushed
the
put_version_in_init_py
branch
from
97fa1cc
to
3dbfe5a
Compare
Close #213