Possibly unused code

[tianjiaoding]

labelme/labelme/app.py

Line 124 in 58693e6

listLayout.addWidget(self.editButton)#, 0, Qt.AlignCenter)

in labelme/app.py
line 117 - 125
listLayout = QVBoxLayout() listLayout.setContentsMargins(0, 0, 0, 0) listLayout.addWidget(self.labelList) self.editButton = QToolButton() self.editButton.setToolButtonStyle(Qt.ToolButtonTextBesideIcon) self.labelListContainer = QWidget() self.labelListContainer.setLayout(listLayout) listLayout.addWidget(self.editButton)#, 0, Qt.AlignCenter) listLayout.addWidget(self.labelList)

1. The listLayout added self.labelList twice.
2. The listLayout added self.editButton, but I didn't see the button in the polygon labels dock. I tested by drawing multiple polygons and delete them, however, there's no sign of this button. Maybe I didn't cover the right usage.
3. The app works the same if I delete the last two lines of the snippet.

git blame shows that the code was introduced like 6 years ago. The readability will be improved if unused code is deleted.

[tianjiaoding]

My apologies. I just turned on advanced mode and saw the edit button. However, I don't quite understand the purpose of adding self.labelList twice. Could someone please explain this a little bit?

[wkentaro]

Hmm, sorry, but that's not where I wrote. And I can't explain it at this moment.

[wkentaro]

I found you're right, and the line can be removed.
This will be resolved via #121

[tianjiaoding]

Thanks for checking, though it’s a minor problem. I discovered that when making my own fork to adapt the tool to label images from multiple cameras. I will release that tool and acknowledge this repository. :)

…

On Apr 10, 2018, at 3:26 PM, Kentaro Wada ***@***.*** ***@***.***>> wrote: I found you're right, and the line can be removed. This will be resolved via #121 <#121> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#66 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AK_dwjm7o-wLE68AENX95PuILVUzwJR-ks5tnF6igaJpZM4SEymS>.

[wkentaro]

Yeah, nice catch. Thanks!