Avoid reconnecting to a broker that failed on us #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I was at it, I also improved the logging of the broker usage. |
RalfJung
changed the title
|
I expanded the scope of the PR to also include a new feature: If connecting to a broker fails, we will not try that broker again because we assume it is broken. This only applies to failure during the initial connection establishment; if the broker disconnects later (e.g. because it got restarted), that's fine. When all brokers got disabled, we enable them all again. This avoids silly loops where for some reason, one broker doesn't work, and hence it has the lowest usage, and hence everyone picks it, and hence nobody can connect. It doesn't catch more higher-level failure though (e.g. l2tp works, but then there is no batman connection). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
broker_selector_usagereturns0when no broker is ready. That's just wrong, a selector should never return a broker that is not ready. It should return-1instead, like the others, which will make broker selection restart.EDIT: I expanded the scope of the PR; see below.