Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotspot reports under long wavelength approximation. We use an adapte… #7

Open
wants to merge 2 commits into
base: devel-factory
Choose a base branch
from

Conversation

guillepo
Copy link
Contributor

…d 2D version of PIC architecture due to F. Huang (2011)

@wlmb
Copy link
Owner

wlmb commented May 2, 2019

The results are very nice, but I don't think they belong to a repository. In particular, the movies are binaries and large, so it might be inconvenient to force future users or collaborators to download them together with the package.

@mohawk2
Copy link
Contributor

mohawk2 commented May 6, 2019

Maybe it would make most sense for @guillepo to put them in their own repo, and to PR a reference to that repo on this one's docs.

That could even be adjusted to use my promised "repro" script for easy consumption!

By the way @wlmb could you release an updated Photonic with the metadata etc from master?

Also, are you interested in a PR updating this to use PDLA? That would need me to port FFTW3 etc as well but that should be easy.

@wlmb
Copy link
Owner

wlmb commented May 6, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants