Fixed compilation on MacOS platforms where Python default target is <10.9 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…10.9. Modified setup.py to set env MACOSX_DEPLOYMENT_TARGET=10.9 when the build MacOS is that or newer, but the default MACOSX_DEPLOYMENT_TARGET (when absent) is <10.9, which happens when the running Python targets <10.9 min. This happens for example when running a current Anaconda Python, which has target 10.7. This fix taken verbatim from similar in Pandas, pandas-dev/pandas#24274 . Fixed wmayner#39.
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, you can still build with Anaconda current Python, even though it is built for minimum MacOS 10.7.
Modified setup.py to set env MACOSX_DEPLOYMENT_TARGET=10.9 when the build
MacOS is that or newer, but the default MACOSX_DEPLOYMENT_TARGET (when absent)
is <10.9, which happens when the running Python targets <10.9 min.
This happens for example when running a current Anaconda Python, which
has target 10.7.
This fix taken verbatim from similar in Pandas,
pandas-dev/pandas#24274 .
Fixed #39.