feat: The phrases nNetwork, nTicket, nTrain and nBus now show the 'n' as an SVG icon #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-782--wmnetwork.netlify.app |
catiarodriguescosta
previously approved these changes
May 14, 2021
gldgrnt
suggested changes
May 14, 2021
houbly
approved these changes
May 17, 2021
catiarodriguescosta
approved these changes
May 19, 2021
Merged
wmcadigital-admin
pushed a commit
that referenced
this pull request
May 19, 2021
# [1.7.0](v1.6.0...v1.7.0) (2021-05-19) ### Bug Fixes * journey planner & buy a ticket buttons ([#795](#795)) ([5f50d2c](5f50d2c)), closes [#788](#788) * journey planner homepage ([#792](#792)) ([fb7aca8](fb7aca8)) * journey planner updates ([#769](#769)) ([f968ff0](f968ff0)) * Re-added linter to check PR titles for semantic versioning ([#774](#774)) ([0c8f5ea](0c8f5ea)) * Updated Content-Type for CSS files when being redirected. ([#758](#758)) ([602bb9b](602bb9b)) * Updated domain redirects so they now point to tfwm.org.uk ([#793](#793)) ([47a64c7](47a64c7)) * Updated transport banner font color to white for all html tags ([#773](#773)) ([17c16c1](17c16c1)) ### Features * add Buy a ticket pattern ([#778](#778)) ([175a7db](175a7db)) * add Homepage banner pattern ([#784](#784)) ([f95ab44](f95ab44)) * add journey planner pattern and update pattern page ([#781](#781)) ([cd44140](cd44140)) * add purple branded banner pattern ([#785](#785)) ([5ce3a3b](5ce3a3b)) * add Swift Content Card ([#779](#779)) ([8110283](8110283)) * add swift sign in/register component ([#780](#780)) ([7ef0890](7ef0890)) * Changes brand assets and brand references to Transport for West Midlands ([#768](#768)) ([a2172e7](a2172e7)), closes [#767](#767) [#766](#766) [#762](#762) [#762](#762) * find timetable pattern ([#771](#771)) ([c76153e](c76153e)) * The phrases nNetwork, nTicket, nTrain and nBus now show the 'n' as an SVG icon ([#782](#782)) ([97f4361](97f4361))
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds functionality to automatically replace phrases such as nBus with an icon + 'bus' as seen in the below screenshot.
However, there is one problem which will need addressing in future. Currently it replaces all innerHTMl within the body element...this strips out all eventListeners in the DOM, to avoid this for now I call the nIcon function before any other javascript runs to avoid it stripping event listeners.
In future, I will explore a way to target a specific class and just replace that only. The reason I haven't done that currently is because content editors don't have this ability in Umbraco (at the moment).