Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Buy a ticket pattern #778

Merged
merged 11 commits into from
May 14, 2021
Merged

feat: add Buy a ticket pattern #778

merged 11 commits into from
May 14, 2021

Conversation

gldgrnt
Copy link
Contributor

@gldgrnt gldgrnt commented May 13, 2021

Fixes #759

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

@github-actions
Copy link

github-actions bot commented May 13, 2021

🚀 Deployed on https://deploy-preview-778--wmnetwork.netlify.app

@gldgrnt gldgrnt linked an issue May 13, 2021 that may be closed by this pull request
Copy link
Contributor

@jkmnch jkmnch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selecting the Train or Tram buttons gives them a purple fill, instead of the standard active button style

Copy link
Contributor

@catiarodriguescosta catiarodriguescosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some suggestions that will turn my / Dayle's life easier. :)
But it is looking good! 👍

src/wmnds/patterns/buy-a-ticket/_buy-a-ticket.njk Outdated Show resolved Hide resolved
src/wmnds/patterns/buy-a-ticket/_buy-a-ticket.njk Outdated Show resolved Hide resolved
src/wmnds/patterns/buy-a-ticket/_buy-a-ticket.njk Outdated Show resolved Hide resolved
src/wmnds/patterns/buy-a-ticket/_buy-a-ticket.njk Outdated Show resolved Hide resolved
src/wmnds/patterns/buy-a-ticket/_buy-a-ticket.njk Outdated Show resolved Hide resolved
Copy link
Contributor

@catiarodriguescosta catiarodriguescosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@houbly houbly merged commit 175a7db into release May 14, 2021
@houbly houbly deleted the gg/feat/buy-a-ticket-pattern branch May 14, 2021 07:35
@github-actions github-actions bot mentioned this pull request May 19, 2021
wmcadigital-admin pushed a commit that referenced this pull request May 19, 2021
# [1.7.0](v1.6.0...v1.7.0) (2021-05-19)

### Bug Fixes

* journey planner & buy a ticket buttons ([#795](#795)) ([5f50d2c](5f50d2c)), closes [#788](#788)
* journey planner homepage ([#792](#792)) ([fb7aca8](fb7aca8))
* journey planner updates ([#769](#769)) ([f968ff0](f968ff0))
* Re-added linter to check PR titles for semantic versioning ([#774](#774)) ([0c8f5ea](0c8f5ea))
* Updated Content-Type for CSS files when being redirected. ([#758](#758)) ([602bb9b](602bb9b))
* Updated domain redirects so they now point to tfwm.org.uk ([#793](#793)) ([47a64c7](47a64c7))
* Updated transport banner font color to white for all html tags ([#773](#773)) ([17c16c1](17c16c1))

### Features

* add Buy a ticket pattern ([#778](#778)) ([175a7db](175a7db))
* add Homepage banner pattern ([#784](#784)) ([f95ab44](f95ab44))
* add journey planner pattern and update pattern page ([#781](#781)) ([cd44140](cd44140))
* add purple branded banner pattern ([#785](#785)) ([5ce3a3b](5ce3a3b))
* add Swift Content Card ([#779](#779)) ([8110283](8110283))
* add swift sign in/register component ([#780](#780)) ([7ef0890](7ef0890))
* Changes brand assets and brand references to Transport for West Midlands ([#768](#768)) ([a2172e7](a2172e7)), closes [#767](#767) [#766](#766) [#762](#762) [#762](#762)
* find timetable pattern ([#771](#771)) ([c76153e](c76153e))
* The phrases nNetwork, nTicket, nTrain and nBus now show the 'n' as an SVG icon ([#782](#782)) ([97f4361](97f4361))
@wmcadigital-admin
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the Buy a ticket pattern which is used on the new homepage
5 participants