Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plan your journey and Buy a ticket widget buttons should be full-width on mobile #788

Closed
jkmnch opened this issue May 18, 2021 · 1 comment · Fixed by #795
Closed

Plan your journey and Buy a ticket widget buttons should be full-width on mobile #788

jkmnch opened this issue May 18, 2021 · 1 comment · Fixed by #795
Assignees
@catiarodriguescosta
Labels
must have Product cannot ship without this feature released

Comments

@jkmnch
Copy link
Contributor

jkmnch commented May 18, 2021 •
edited
Loading

Describe the bug
The buttons in the new Plan your journey and Buy a ticket widgets should be full-width in mobile viewports.

This is what they currently look like on the homepage:

Screenshot 2021-05-18 at 09 56 31

Mobile homepage in Zeplin: https://zpl.io/257qppn
@jkmnch jkmnch added the must have Product cannot ship without this feature label May 18, 2021
@catiarodriguescosta catiarodriguescosta self-assigned this May 19, 2021
catiarodriguescosta added a commit that referenced this issue May 19, 2021
@catiarodriguescosta
Fix bug with buttons on mobile. Fixes #788.
b3b0ae2
@catiarodriguescosta catiarodriguescosta mentioned this issue May 19, 2021
Merged
@catiarodriguescosta catiarodriguescosta linked a pull request May 19, 2021 that will close this issue
fix: journey planner & buy a ticket buttons #795
Merged
wmcadigital-admin pushed a commit that referenced this issue May 19, 2021
@semantic-release-bot
chore(release): 1.7.0 [skip ci]
3614cb4 
# [1.7.0](v1.6.0...v1.7.0) (2021-05-19)

### Bug Fixes

* journey planner & buy a ticket buttons ([#795](#795)) ([5f50d2c](5f50d2c)), closes [#788](#788)
* journey planner homepage ([#792](#792)) ([fb7aca8](fb7aca8))
* journey planner updates ([#769](#769)) ([f968ff0](f968ff0))
* Re-added linter to check PR titles for semantic versioning ([#774](#774)) ([0c8f5ea](0c8f5ea))
* Updated Content-Type for CSS files when being redirected. ([#758](#758)) ([602bb9b](602bb9b))
* Updated domain redirects so they now point to tfwm.org.uk ([#793](#793)) ([47a64c7](47a64c7))
* Updated transport banner font color to white for all html tags ([#773](#773)) ([17c16c1](17c16c1))

### Features

* add Buy a ticket pattern ([#778](#778)) ([175a7db](175a7db))
* add Homepage banner pattern ([#784](#784)) ([f95ab44](f95ab44))
* add journey planner pattern and update pattern page ([#781](#781)) ([cd44140](cd44140))
* add purple branded banner pattern ([#785](#785)) ([5ce3a3b](5ce3a3b))
* add Swift Content Card ([#779](#779)) ([8110283](8110283))
* add swift sign in/register component ([#780](#780)) ([7ef0890](7ef0890))
* Changes brand assets and brand references to Transport for West Midlands ([#768](#768)) ([a2172e7](a2172e7)), closes [#767](#767) [#766](#766) [#762](#762) [#762](#762)
* find timetable pattern ([#771](#771)) ([c76153e](c76153e))
* The phrases nNetwork, nTicket, nTrain and nBus now show the 'n' as an SVG icon ([#782](#782)) ([97f4361](97f4361))
@wmcadigital-admin
Copy link

🎉 This issue has been resolved in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@catiarodriguescosta catiarodriguescosta

Labels
must have Product cannot ship without this feature released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: journey planner & buy a ticket buttons wmcadigital/wmn-design-system
3 participants
@catiarodriguescosta @jkmnch @wmcadigital-admin