Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: find timetable pattern #771

Merged
merged 25 commits into from
May 19, 2021
Merged

feat: find timetable pattern #771

merged 25 commits into from
May 19, 2021

Conversation

catiarodriguescosta
Copy link
Contributor

@catiarodriguescosta catiarodriguescosta commented May 10, 2021 •
edited
Loading

Fixes #760

@catiarodriguescosta catiarodriguescosta marked this pull request as draft May 10, 2021 14:39
@github-actions
Copy link

github-actions bot commented May 10, 2021 •
edited
Loading

🚀 Deployed on https://deploy-preview-771--wmnetwork.netlify.app

@mrmjprice mrmjprice self-requested a review May 11, 2021 10:16
mrmjprice
mrmjprice suggested changes May 11, 2021
View reviewed changes
Copy link
Contributor

@mrmjprice mrmjprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you find a replace Find timetable and replace it with Find a timetable to add an 'a'? Thank you.

@mrmjprice mrmjprice linked an issue May 14, 2021 that may be closed by this pull request
Add the Find a timetable pattern which is used on the new homepage #760
Closed
@catiarodriguescosta catiarodriguescosta marked this pull request as ready for review May 14, 2021 10:00
gldgrnt
gldgrnt suggested changes May 14, 2021
View reviewed changes
Copy link
Contributor

@gldgrnt gldgrnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good with markup/styles, but title and page link are 'Find ticket' instead of 'Find a ticket' (and this causes a 404 when you click the link in the navigation or sidebar)

src/www/data.njk.json Outdated Show resolved Hide resolved
src/wmnds/patterns/find-a-timetable-widget/_find-a-timetable-widget.njk Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
catiarodriguescosta and others added 3 commits May 17, 2021 09:36
@catiarodriguescosta @gldgrnt
Update page title
d377bda 
Co-authored-by: Gil <43111519+gldgrnt@users.noreply.github.com>
@catiarodriguescosta @gldgrnt
Update src/wmnds/patterns/find-a-timetable-widget/_find-a-timetable-w…
adb7801 
…idget.njk

Co-authored-by: Gil <43111519+gldgrnt@users.noreply.github.com>
@catiarodriguescosta
remove vscode custom settings
fecd9e4
houbly
houbly previously approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@houbly houbly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

jkmnch
jkmnch suggested changes May 17, 2021
View reviewed changes
Copy link
Contributor

@jkmnch jkmnch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The train and tram buttons should be switched, so the order is Bus, Train and Tram.

Also, the 'Anything else' section is just for reference in the GitHub issue and shouldn't be in the DS.

jkmnch
jkmnch suggested changes May 17, 2021
View reviewed changes
Copy link
Contributor

@jkmnch jkmnch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, last change! The Train button links to the correct timetables page on the old site, but the Tram button doesn't. Can the Tram button be linked to here? https://www.networkwestmidlands.com/plan-your-journey/timetables/#/?mode=Tram&serviceNo=MM1&limit=6

@catiarodriguescosta
Copy link
Contributor Author

Sorry, last change! The Train button links to the correct timetables page on the old site, but the Tram button doesn't. Can the Tram button be linked to here? https://www.networkwestmidlands.com/plan-your-journey/timetables/#/?mode=Tram&serviceNo=MM1&limit=6

No problem Jake, it's fixe now. Thanks for all the checks! :)

jkmnch
jkmnch suggested changes May 17, 2021
View reviewed changes
Copy link
Contributor

@jkmnch jkmnch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link doesn't work for me strangely. It reverts back to the default Timetables page when I click on the button. I don't think that link will work. It might have to be changed to this one instead: https://www.networkwestmidlands.com/plan-your-journey/timetables/#/route/cen_01MM1_%20_H_y11_26-26

jkmnch
jkmnch previously approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@jkmnch jkmnch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks Catia :)

gldgrnt
gldgrnt approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@gldgrnt gldgrnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me

@catiarodriguescosta catiarodriguescosta merged commit c76153e into release May 19, 2021
@catiarodriguescosta catiarodriguescosta deleted the CC/feature/find-timetable-pattern branch May 19, 2021 10:23
@github-actions github-actions bot mentioned this pull request May 19, 2021
Merged
wmcadigital-admin pushed a commit that referenced this pull request May 19, 2021
@semantic-release-bot
chore(release): 1.7.0 [skip ci]
3614cb4 
# [1.7.0](v1.6.0...v1.7.0) (2021-05-19)

### Bug Fixes

* journey planner & buy a ticket buttons ([#795](#795)) ([5f50d2c](5f50d2c)), closes [#788](#788)
* journey planner homepage ([#792](#792)) ([fb7aca8](fb7aca8))
* journey planner updates ([#769](#769)) ([f968ff0](f968ff0))
* Re-added linter to check PR titles for semantic versioning ([#774](#774)) ([0c8f5ea](0c8f5ea))
* Updated Content-Type for CSS files when being redirected. ([#758](#758)) ([602bb9b](602bb9b))
* Updated domain redirects so they now point to tfwm.org.uk ([#793](#793)) ([47a64c7](47a64c7))
* Updated transport banner font color to white for all html tags ([#773](#773)) ([17c16c1](17c16c1))

### Features

* add Buy a ticket pattern ([#778](#778)) ([175a7db](175a7db))
* add Homepage banner pattern ([#784](#784)) ([f95ab44](f95ab44))
* add journey planner pattern and update pattern page ([#781](#781)) ([cd44140](cd44140))
* add purple branded banner pattern ([#785](#785)) ([5ce3a3b](5ce3a3b))
* add Swift Content Card ([#779](#779)) ([8110283](8110283))
* add swift sign in/register component ([#780](#780)) ([7ef0890](7ef0890))
* Changes brand assets and brand references to Transport for West Midlands ([#768](#768)) ([a2172e7](a2172e7)), closes [#767](#767) [#766](#766) [#762](#762) [#762](#762)
* find timetable pattern ([#771](#771)) ([c76153e](c76153e))
* The phrases nNetwork, nTicket, nTrain and nBus now show the 'n' as an SVG icon ([#782](#782)) ([97f4361](97f4361))
@wmcadigital-admin
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houbly houbly houbly approved these changes

@mrmjprice mrmjprice mrmjprice approved these changes

@gldgrnt gldgrnt gldgrnt approved these changes

@jkmnch jkmnch jkmnch left review comments

@daylesalmon daylesalmon Awaiting requested review from daylesalmon

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the Find a timetable pattern which is used on the new homepage
6 participants
@catiarodriguescosta @wmcadigital-admin @houbly @mrmjprice @gldgrnt @jkmnch