Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Swift Content Card #779

Merged
merged 5 commits into from
May 14, 2021
Merged

feat: add Swift Content Card #779

merged 5 commits into from
May 14, 2021

Conversation

houbly
Copy link
Contributor

@houbly houbly commented May 13, 2021

fixes #777

@github-actions
Copy link

github-actions bot commented May 13, 2021

🚀 Deployed on https://deploy-preview-779--wmnetwork.netlify.app

Copy link
Contributor

@gldgrnt gldgrnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but is missing the 'When not to use it?' section. Also added bullet point suggestion to keep the content consistent with the rest of the page.


<h3>What does it do?</h3>

Shows the image of Swift card and explains how to purchase it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Shows the image of Swift card and explains how to purchase it
- Shows the image of Swift card and explains how to purchase it


<h3>When to use it?</h3>

Only on Swift product landing pages such as Swift Go and PAYG
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Only on Swift product landing pages such as Swift Go and PAYG
- Only on Swift product landing pages such as Swift Go and PAYG

@houbly houbly requested a review from gldgrnt May 14, 2021 07:34
@houbly houbly linked an issue May 14, 2021 that may be closed by this pull request
Copy link

@KaterinaKir KaterinaKir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@gldgrnt gldgrnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@gldgrnt gldgrnt merged commit 8110283 into release May 14, 2021
@gldgrnt gldgrnt deleted the hb/feat/swift-content-card branch May 14, 2021 08:36
@mrmjprice
Copy link
Contributor

wmcadigital/wmn-cms#114

@github-actions github-actions bot mentioned this pull request May 19, 2021
wmcadigital-admin pushed a commit that referenced this pull request May 19, 2021
# [1.7.0](v1.6.0...v1.7.0) (2021-05-19)

### Bug Fixes

* journey planner & buy a ticket buttons ([#795](#795)) ([5f50d2c](5f50d2c)), closes [#788](#788)
* journey planner homepage ([#792](#792)) ([fb7aca8](fb7aca8))
* journey planner updates ([#769](#769)) ([f968ff0](f968ff0))
* Re-added linter to check PR titles for semantic versioning ([#774](#774)) ([0c8f5ea](0c8f5ea))
* Updated Content-Type for CSS files when being redirected. ([#758](#758)) ([602bb9b](602bb9b))
* Updated domain redirects so they now point to tfwm.org.uk ([#793](#793)) ([47a64c7](47a64c7))
* Updated transport banner font color to white for all html tags ([#773](#773)) ([17c16c1](17c16c1))

### Features

* add Buy a ticket pattern ([#778](#778)) ([175a7db](175a7db))
* add Homepage banner pattern ([#784](#784)) ([f95ab44](f95ab44))
* add journey planner pattern and update pattern page ([#781](#781)) ([cd44140](cd44140))
* add purple branded banner pattern ([#785](#785)) ([5ce3a3b](5ce3a3b))
* add Swift Content Card ([#779](#779)) ([8110283](8110283))
* add swift sign in/register component ([#780](#780)) ([7ef0890](7ef0890))
* Changes brand assets and brand references to Transport for West Midlands ([#768](#768)) ([a2172e7](a2172e7)), closes [#767](#767) [#766](#766) [#762](#762) [#762](#762)
* find timetable pattern ([#771](#771)) ([c76153e](c76153e))
* The phrases nNetwork, nTicket, nTrain and nBus now show the 'n' as an SVG icon ([#782](#782)) ([97f4361](97f4361))
@wmcadigital-admin
Copy link

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swift card / Content Card
5 participants