Fixed case issue #731

sudheer-rk · 2023-05-12T08:48:10Z

Fixed case issue

* website title and replan journey URL updated * updated description and short name * added new header and footer link to index page * amend header and update social media link on share-button * update feedback link and key * updated feedback link id * updated feedback link id * reinstall package-lock * remove feedback link and reinstall package-lock * reinstall package-lock * remove unused vars Co-authored-by: Sudheer Kotha <SudheerKotha@wmca.org.uk> Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

* moved feedback link to env variable and updated the header * add keys to netlify and remove unused vars on header Co-authored-by: Sudheer Kotha <SudheerKotha@wmca.org.uk> Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

* website title and replan journey URL updated * updated description and short name * added new header and footer link to index page * amend header and update social media link on share-button * update feedback link and key * updated feedback link id * updated feedback link id * reinstall package-lock * remove feedback link and reinstall package-lock * reinstall package-lock * remove unused vars * updating twitter and email links Co-authored-by: Sudheer Kotha <SudheerKotha@wmca.org.uk> Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

* align the filter options and change the button styling for map and list * replacing locate map icon and updating zoom map icons * alignment of filter options and map button styling Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

* npm-check-updates applied to project * updated comments * clear npm cache and replace propTypes any with propTypes object * fix es-lint error to move disruptionsData in its own useMemo() hook Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

* ncu updates applied to project * updated comments * clear npm cache and replacing propTypes any with propTypes object * fix eslint error to move disruptionsData in its own useMemo() hook * applied npm upgrade and show header title smaller for mobiles Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

* ncu updates applied to project * updated comments * clear npm cache and replacing propTypes any with propTypes object * fix eslint error to move disruptionsData in its own useMemo() hook * applied npm upgrade and show header title smaller for mobiles * update node module and adjusted title margin Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

* adjusted header for mobile screen * adjusted header margin Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

…ce' (#670) * added new message type NoKnownDisruptionMessage replacing 'good service' * remove strike message Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

* added new message type NoKnownDisruptionMessage replacing 'good service' * remove strike message * replacing GoodServiceMessage with NoKnownDisruptionMessage Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

* integrating rail station graph with tram disruptions * replaced atcoCode filter with naPTAN * Empty-Commit * removed unexpected console statement. Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

* amendments to toggle more affected items * Restyled by prettier (#700) Co-authored-by: Restyled.io <commits@restyled.io> * resolving prettier build issue * resolving prettier issue * Restyled by prettier (#702) Co-authored-by: Restyled.io <commits@restyled.io> * Restyled by prettier is not working Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>

Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

) * Feature/203 links and branding (#642) * website title and replan journey URL updated * updated description and short name * added new header and footer link to index page * amend header and update social media link on share-button * update feedback link and key * updated feedback link id * updated feedback link id * reinstall package-lock * remove feedback link and reinstall package-lock * reinstall package-lock * remove unused vars Co-authored-by: Sudheer Kotha <SudheerKotha@wmca.org.uk> Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Bug/203 links filter and video (#645) * moved feedback link to env variable and updated the header * add keys to netlify and remove unused vars on header Co-authored-by: Sudheer Kotha <SudheerKotha@wmca.org.uk> Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Feature/203 links and branding (#649) * website title and replan journey URL updated * updated description and short name * added new header and footer link to index page * amend header and update social media link on share-button * update feedback link and key * updated feedback link id * updated feedback link id * reinstall package-lock * remove feedback link and reinstall package-lock * reinstall package-lock * remove unused vars * updating twitter and email links Co-authored-by: Sudheer Kotha <SudheerKotha@wmca.org.uk> Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Feature/204 upgrade disruptions UI in line with tfwm (#650) * align the filter options and change the button styling for map and list * replacing locate map icon and updating zoom map icons * alignment of filter options and map button styling Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * ncu updates applied to project (#653) * npm-check-updates applied to project * updated comments * clear npm cache and replace propTypes any with propTypes object * fix es-lint error to move disruptionsData in its own useMemo() hook Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Feature/upgrade node and other dependencies (#656) * ncu updates applied to project * updated comments * clear npm cache and replacing propTypes any with propTypes object * fix eslint error to move disruptionsData in its own useMemo() hook * applied npm upgrade and show header title smaller for mobiles Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Feature/upgrade node and other dependencies (#657) * ncu updates applied to project * updated comments * clear npm cache and replacing propTypes any with propTypes object * fix eslint error to move disruptionsData in its own useMemo() hook * applied npm upgrade and show header title smaller for mobiles * update node module and adjusted title margin Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Feature/adjust header and footer (#658) * adjusted header for mobile screen * adjusted header margin Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * npm install changes updated after mergt * added new message type NoKnownDisruptionMessage replacing 'good service' (#670) * added new message type NoKnownDisruptionMessage replacing 'good service' * remove strike message Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Bug/change good service to unknown disruption (#671) * added new message type NoKnownDisruptionMessage replacing 'good service' * remove strike message * replacing GoodServiceMessage with NoKnownDisruptionMessage Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> Co-authored-by: Sudheer Kotha <SudheerKotha@wmca.org.uk> Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> Co-authored-by: Sudheer Kotha <SudheerKotha@wmca.org.uk> Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

* Feature/revise text on Disruptions when no known disruption (#677) * Feature/203 links and branding (#642) * website title and replan journey URL updated * updated description and short name * added new header and footer link to index page * amend header and update social media link on share-button * update feedback link and key * updated feedback link id * updated feedback link id * reinstall package-lock * remove feedback link and reinstall package-lock * reinstall package-lock * remove unused vars Co-authored-by: Sudheer Kotha <SudheerKotha@wmca.org.uk> Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Bug/203 links filter and video (#645) * moved feedback link to env variable and updated the header * add keys to netlify and remove unused vars on header Co-authored-by: Sudheer Kotha <SudheerKotha@wmca.org.uk> Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Feature/203 links and branding (#649) * website title and replan journey URL updated * updated description and short name * added new header and footer link to index page * amend header and update social media link on share-button * update feedback link and key * updated feedback link id * updated feedback link id * reinstall package-lock * remove feedback link and reinstall package-lock * reinstall package-lock * remove unused vars * updating twitter and email links Co-authored-by: Sudheer Kotha <SudheerKotha@wmca.org.uk> Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Feature/204 upgrade disruptions UI in line with tfwm (#650) * align the filter options and change the button styling for map and list * replacing locate map icon and updating zoom map icons * alignment of filter options and map button styling Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * ncu updates applied to project (#653) * npm-check-updates applied to project * updated comments * clear npm cache and replace propTypes any with propTypes object * fix es-lint error to move disruptionsData in its own useMemo() hook Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Feature/upgrade node and other dependencies (#656) * ncu updates applied to project * updated comments * clear npm cache and replacing propTypes any with propTypes object * fix eslint error to move disruptionsData in its own useMemo() hook * applied npm upgrade and show header title smaller for mobiles Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Feature/upgrade node and other dependencies (#657) * ncu updates applied to project * updated comments * clear npm cache and replacing propTypes any with propTypes object * fix eslint error to move disruptionsData in its own useMemo() hook * applied npm upgrade and show header title smaller for mobiles * update node module and adjusted title margin Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Feature/adjust header and footer (#658) * adjusted header for mobile screen * adjusted header margin Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * npm install changes updated after mergt * added new message type NoKnownDisruptionMessage replacing 'good service' (#670) * added new message type NoKnownDisruptionMessage replacing 'good service' * remove strike message Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Bug/change good service to unknown disruption (#671) * added new message type NoKnownDisruptionMessage replacing 'good service' * remove strike message * replacing GoodServiceMessage with NoKnownDisruptionMessage Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> Co-authored-by: Sudheer Kotha <SudheerKotha@wmca.org.uk> Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * added random string with api call * Empty-Commit * remove spaces * remove log info --------- Co-authored-by: Sudheer Kotha <SudheerKotha@wmca.org.uk> Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

* Feature/revise text on Disruptions when no known disruption (#677) * Feature/203 links and branding (#642) * website title and replan journey URL updated * updated description and short name * added new header and footer link to index page * amend header and update social media link on share-button * update feedback link and key * updated feedback link id * updated feedback link id * reinstall package-lock * remove feedback link and reinstall package-lock * reinstall package-lock * remove unused vars Co-authored-by: Sudheer Kotha <SudheerKotha@wmca.org.uk> Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Bug/203 links filter and video (#645) * moved feedback link to env variable and updated the header * add keys to netlify and remove unused vars on header Co-authored-by: Sudheer Kotha <SudheerKotha@wmca.org.uk> Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Feature/203 links and branding (#649) * website title and replan journey URL updated * updated description and short name * added new header and footer link to index page * amend header and update social media link on share-button * update feedback link and key * updated feedback link id * updated feedback link id * reinstall package-lock * remove feedback link and reinstall package-lock * reinstall package-lock * remove unused vars * updating twitter and email links Co-authored-by: Sudheer Kotha <SudheerKotha@wmca.org.uk> Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Feature/204 upgrade disruptions UI in line with tfwm (#650) * align the filter options and change the button styling for map and list * replacing locate map icon and updating zoom map icons * alignment of filter options and map button styling Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * ncu updates applied to project (#653) * npm-check-updates applied to project * updated comments * clear npm cache and replace propTypes any with propTypes object * fix es-lint error to move disruptionsData in its own useMemo() hook Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Feature/upgrade node and other dependencies (#656) * ncu updates applied to project * updated comments * clear npm cache and replacing propTypes any with propTypes object * fix eslint error to move disruptionsData in its own useMemo() hook * applied npm upgrade and show header title smaller for mobiles Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Feature/upgrade node and other dependencies (#657) * ncu updates applied to project * updated comments * clear npm cache and replacing propTypes any with propTypes object * fix eslint error to move disruptionsData in its own useMemo() hook * applied npm upgrade and show header title smaller for mobiles * update node module and adjusted title margin Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Feature/adjust header and footer (#658) * adjusted header for mobile screen * adjusted header margin Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * npm install changes updated after mergt * added new message type NoKnownDisruptionMessage replacing 'good service' (#670) * added new message type NoKnownDisruptionMessage replacing 'good service' * remove strike message Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * Bug/change good service to unknown disruption (#671) * added new message type NoKnownDisruptionMessage replacing 'good service' * remove strike message * replacing GoodServiceMessage with NoKnownDisruptionMessage Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> Co-authored-by: Sudheer Kotha <SudheerKotha@wmca.org.uk> Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk> * added random string with api call * Empty-Commit * remove spaces * remove log info * log randomString --------- Co-authored-by: Sudheer Kotha <SudheerKotha@wmca.org.uk> Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

* group disruptions linas and operators and new styles * refined to display routes grouped by operators * updated styles * amendments to the disruption list * applying styles and adding severity setting --------- Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

gitguardian · 2023-05-12T08:48:16Z

⚠️ GitGuardian has uncovered 9 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
1065342	Generic High Entropy Secret	`10b2183`	.env.development	View secret
1065341	Generic High Entropy Secret	`10b2183`	.env.production	View secret
1065342	Generic High Entropy Secret	`10b2183`	netlify.toml	View secret
1065342	Generic High Entropy Secret	`3243d9a`	.env.development	View secret
1489744	Generic High Entropy Secret	`3243d9a`	.env.development	View secret
1489744	Generic High Entropy Secret	`bee26a4`	.env.development	View secret
1065342	Generic High Entropy Secret	`bee26a4`	.env.development	View secret
1065342	Generic High Entropy Secret	`7d9b4cc`	.env.development	View secret
1489744	Generic High Entropy Secret	`7d9b4cc`	.env.development	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

sudheer-rk and others added 30 commits August 11, 2022 08:27

Bug/203 links filter and video (#645)

10b2183

* moved feedback link to env variable and updated the header * add keys to netlify and remove unused vars on header Co-authored-by: Sudheer Kotha <SudheerKotha@wmca.org.uk> Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

Feature/adjust header and footer (#658)

3a5e67f

* adjusted header for mobile screen * adjusted header margin Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

merge master into develop

58f95c3

npm install changes updated after mergt

703e4ff

added new message type NoKnownDisruptionMessage replacing 'good servi…

71938ce

…ce' (#670) * added new message type NoKnownDisruptionMessage replacing 'good service' * remove strike message Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

Bug/change good service to unknown disruption (#671)

5b23390

* added new message type NoKnownDisruptionMessage replacing 'good service' * remove strike message * replacing GoodServiceMessage with NoKnownDisruptionMessage Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

Merge 'master' into develop

d6b1e11

Identify and fix issue with API returning empty array (#679)

ca412d9

* integrating rail station graph with tram disruptions * replaced atcoCode filter with naPTAN * Empty-Commit * removed unexpected console statement. Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

update staging environment with new api key

3243d9a

rollback dependencies updated previously

55752c2

rolled back api key

bee26a4

updated with new api key

7d9b4cc

rollback package lock file as a test

61fa361

remove extra 's' on the end of the api endpoint

bb804bb

added 'show more lines' toggle link to trams (#697)

48b1355

Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

implementing disruptions lines display list (#707)

f20af1e

Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

testing branch eslint (#721)

7030601

Co-authored-by: Sudheer Kotha <sudheer.kotha@wmca@org.uk>

Merge 'master' into develop & fix Severity level.

adf6efa

merge master into develop & fix severity

7449ed1

Sudheer Kotha added 5 commits May 11, 2023 20:38

Merge branch 'master' into develop

bc646a3

urgent fix: hard coded industrial action text

ee41f16

show disruption descriptions on trains

7dc171d

fixed case issue

9cdfdfb

merge branch 'master' into develop

252f070

sudheer-rk added the bug Something isn't working label May 12, 2023

sudheer-rk requested a review from sam-wmca May 12, 2023 08:48

sudheer-rk self-assigned this May 12, 2023

sudheer-rk merged commit cca096b into master May 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed case issue #731

Fixed case issue #731

sudheer-rk commented May 12, 2023

gitguardian bot commented May 12, 2023

Fixed case issue #731

Fixed case issue #731

Conversation

sudheer-rk commented May 12, 2023

gitguardian bot commented May 12, 2023

⚠️ GitGuardian has uncovered 9 secrets following the scan of your pull request.