Re-enable disabled PHPMD rules #36
Conversation
| @@ -10,7 +10,12 @@ | |||
| </rule> | |||
| <rule ref="rulesets/codesize.xml/TooManyMethods"> | |||
| <properties> | |||
| <property name="maxmethods" value="20" /> | |||
| <property name="maxmethods" value="16" /> | |||
There was a problem hiding this comment.
Considering this counts private methods, I rather not decrease this
There was a problem hiding this comment.
I think we discussed this. In a small component like this it makes sense to lower such limits to the smallest number possible. If we ever want to add code that needs a slightly higher limit it's very easy (at least I hope it is) to increase this number in the same patch. It becomes part of the review then.
|
Inactive and needs to made to work with master |
|
Not that I mind very much, as I never found PHPMD's ruleset that helpful. But: when was PHPMD removed from master? What was the reasoning, where is the pull request that did it, and who approved it? |
|
Briefly looking at the history it seems it has been dropped when moving up to PHP 7 as a minimum version (PHPMD didn't work well with PHP 7 or so), which I guess made sense. |
|
And who approved it? |
This is split from #31.