Allow running phpmd separately #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| return false; | ||
| return (bool)array_filter( array_keys( $array ), 'is_string' ); |
There was a problem hiding this comment.
So if you got an associative array with a thousand elements, it'll now do a thousand iterations instead of one? Decreasing the quality of the code just to match a fault CS rule is the opposite of what these tools intend you to do.
There was a problem hiding this comment.
Daniel would say something about premature optimization at this point. I even micro-benchmarked this. It's fine.
Not that you get me wrong: I'm perfectly fine with reverting this to the foreach loop.
thiemowmde
changed the title
JeroenDeDauw
added a commit
that referenced
this pull request
Mar 13, 2015
Allow running phpmd separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I played around with PHPMD and am a bit disappointed. It's not possible to set a number like "this rule is allowed to be broken x times in the legacy code base, but report any new exception".
composer mdcomposer phpcsandcomposer phpmdcommands.composer csdoes not execute PHPMD any more, butcomposer cistill doesRe-enabled all rules with limits that are exactly as high as the current code is(see Re-enable disabled PHPMD rules #36).Re-wrote one method because of the unused variables rule(reverted).