Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SnakList constructor #439

Merged
merged 1 commit into from
Mar 14, 2017
Merged

Add SnakList constructor #439

merged 1 commit into from
Mar 14, 2017

Conversation

thiemowmde
Copy link
Contributor

This introduces a constructor to the SnakList class that does not call the parent constructor. This is done on purpose to decrease the inheritance and possibly get rid of the ArrayObject dependency some day.

This also drops the possibility to call the constructor with null and adds the possibility to call it with variable length arguments (as some similar constructors and add methods already do).

This is split from #416.

@thiemowmde thiemowmde added this to the 3.0 milestone Apr 13, 2015
@JeroenDeDauw JeroenDeDauw removed this from the 3.0 milestone Apr 23, 2015
@JeroenDeDauw
Copy link
Contributor

There are comments by @snaterlicious and me on #376 questioning the merrit of this change.

@thiemowmde
Copy link
Contributor Author

Note that the comment above is not applicable any more because I removed the "variable number of arguments" feature entirely.

@bekh6ex bekh6ex merged commit 2a3984a into master Mar 14, 2017
@thiemowmde thiemowmde deleted the snakListConstructor branch March 14, 2017 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants