Move Hashable interface from HashArray to SnakList #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiemowmde
force-pushed
the
moveGetSnakListHash
branch
from
1df8909
to
e5d0f9d
Compare
bekh6ex
reviewed
Mar 8, 2017
tests/unit/Snak/SnakListTest.php
Outdated
|
|
||
| return [ | ||
| 'same equal object' => [ $empty, $empty ], | ||
| 'same non-equal object' => [ $oneSnak, $oneSnak ], |
There was a problem hiding this comment.
Probably you meant 'same empty object' and 'same non-empty object'
There was a problem hiding this comment.
Yea, thanks! Fixed.
thiemowmde
force-pushed
the
moveGetSnakListHash
branch
from
e5d0f9d
to
f6ac19e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes along with #713 (and will run into a merge conflict – feel free to merge whichever first, I will do the rebase). Both are split from #702 to make that big patch it easier to review later.
Note that I rewrote the tests entirely. This is also the main reason for this patch, to make sure SnakList is properly covered with tests before we are applying the big change in #702.