Validate amount #194
Merged
Validate amount #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @license GNU GPL v2+ | ||
| * @author Gabriel Birke < gabriel.birke@wikimedia.de > | ||
| */ | ||
| class ValidateAmountUseCase { |
There was a problem hiding this comment.
This usecase is somewhat of an empty partition. What do you think about omitting it in this case, by using the AmountValidator directly in the route?
There was a problem hiding this comment.
Deviation from the architecture? 😮
I can certainly do that.
There was a problem hiding this comment.
I actually gave this exact case as an example of where to deviate to Kai... kinda facepalm now at the communication
gbirke
force-pushed
the
validate_amount
branch
from
c11ab30
to
c321890
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on https://phabricator.wikimedia.org/T127001