Add containsStringIgnoringWhiteSpace matcher #2
Conversation
|
I don't mind @bekh6ex, thanks! |
I guess more or less. |
| */ | ||
| private function stripSpace( $string) | ||
| { | ||
| return trim(preg_replace( "/\s+/", ' ', $string)); |
There was a problem hiding this comment.
Because this is in double quotes this technically needs to be "/\\s+/". But this is not critical. All the missing backslash does is creating a warning in IDEs.
| */ | ||
| protected function evalSubstringOf($item) | ||
| { | ||
| return (false !== strpos($this->stripSpace((string) $item), $this->stripSpace($this->_substring))); |
There was a problem hiding this comment.
Not that it matters much, but I find this order a bit surprising.
thiemowmde
force-pushed
the
contains-string-ignoring-white-space
branch
from
c6bdac3
to
b332dcb
Compare
|
I rebased this patch, squashed all of the tiny commits that contained nothing but fixups for previous commits, reformatted the code according to the current PHPCS rules, and finally removed most of the now obsolete comments I wrote here in the review thread (along with some by Aleksey that said nothing but "done"). I don't know if this is still needed. Please either merge this or close #1. |
This would allow to make asserts against multi-line HTML pieces, see: #1.