Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paging by adding options to options.params #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jacknugent
Copy link

@jacknugent jacknugent commented Mar 10, 2020

Addresses #3

This module fails if DynamoDB has to implement paging. You can recreate the error by trying to source from a DynamoDB that has over 1mb of data (1mb is the limit for one payload).

The failure is that params is undefined. Easy fix -- this PR simply changes params to options.params and then paging works fine.

@jacknugent jacknugent mentioned this pull request Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant