Merge pull request #69 from wmnsk/test-uint8-ie

Add tests for methods that return uint8 values
wmnsk · Oct 28, 2020 · a872333 · a872333
2 parents 61e261a + f23d846
commit a872333
Show file tree

Hide file tree

Showing 8 changed files with 854 additions and 19 deletions.
diff --git a/ie/atsss-ll-control-information.go b/ie/atsss-ll-control-information.go
@@ -20,8 +20,8 @@ func (i *IE) ATSSSLLControlInformation() (uint8, error) {
 	switch i.Type {
 	case ATSSSLLControlInformation:
 		return i.Payload[0], nil
-	case ATSSSControlParameters:
-		ies, err := i.ATSSSControlParameters()
+	case ProvideATSSSControlInformation:
+		ies, err := i.ProvideATSSSControlInformation()
 		if err != nil {
 			return 0, err
 		}

diff --git a/ie/bar-id.go b/ie/bar-id.go
@@ -44,17 +44,6 @@ func (i *IE) BARID() (uint8, error) {
 			}
 		}
 		return 0, ErrIENotFound
-	case QueryURR:
-		ies, err := i.QueryURR()
-		if err != nil {
-			return 0, err
-		}
-		for _, x := range ies {
-			if x.Type == BARID {
-				return x.BARID()
-			}
-		}
-		return 0, ErrIENotFound
 	case CreateBAR:
 		ies, err := i.CreateBAR()
 		if err != nil {

diff --git a/ie/dropped-dl-traffic-threshold.go b/ie/dropped-dl-traffic-threshold.go
@@ -10,6 +10,8 @@ import (
 )
 
 // NewDroppedDLTrafficThreshold creates a new DroppedDLTrafficThreshold IE.
+//
+// TODO: structurize
 func NewDroppedDLTrafficThreshold(dlpa, dlby bool, packets, bytes uint64) *IE {
 	if dlpa {
 		if dlby { // has both
@@ -38,6 +40,8 @@ func NewDroppedDLTrafficThreshold(dlpa, dlby bool, packets, bytes uint64) *IE {
 }
 
 // DroppedDLTrafficThreshold returns DroppedDLTrafficThreshold in uint8 if the type of IE matches.
+//
+// TODO: implement!
 func (i *IE) DroppedDLTrafficThreshold() (uint8, error) {
 	if len(i.Payload) < 1 {
 		return 0, io.ErrUnexpectedEOF

diff --git a/ie/ethernet-filter-properties.go b/ie/ethernet-filter-properties.go
@@ -26,7 +26,7 @@ func (i *IE) EthernetFilterProperties() (uint8, error) {
 			return 0, err
 		}
 		for _, x := range ies {
-			if x.Type == EthernetPacketFilter {
+			if x.Type == EthernetFilterProperties {
 				return x.EthernetFilterProperties()
 			}
 		}