Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad handling of PFD Content IE #106

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Fix bad handling of PFD Content IE #106

merged 2 commits into from
Oct 18, 2022

Conversation

john721
Copy link

@john721 john721 commented Oct 8, 2022

3 test cases added:

  1. PFD Content with only 2 octets payload ("Flag" + "Spare"), no FD, no URL.... when PFD is deleted.
  2. Add NodeID to case1
  3. With longer FD & AFD.

@john721
Copy link
Author

john721 commented Oct 8, 2022

pfdMgmtReq.pcap.zip
Attached file contains 2 packets, they are:

  1. case 2 : "Empty PFDContent + NodeID"
  2. case 3 : "PFDContent(FD + AFD) + NodeID"
    Please view the packet file with up-to-date Wireshark (e.g. Version 4.0.0),
    older Wireshark versions may mark 1st packet as malformed.

wmnsk
wmnsk approved these changes Oct 18, 2022
View reviewed changes
Copy link
Owner

@wmnsk wmnsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@wmnsk wmnsk merged commit b59ed2a into wmnsk:master Oct 18, 2022
@john721 john721 deleted the Fix-PFDContents branch October 18, 2022 12:20
@wmnsk wmnsk mentioned this pull request Jul 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmnsk wmnsk wmnsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@john721 @wmnsk