Skip to content
This repository has been archived by the owner on Jan 26, 2019. It is now read-only.

Add full support for generator functions #194

Closed
wants to merge 5 commits into from
Closed

Add full support for generator functions #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6608461
Added babel-loader to the TypeScript pipeline, and enabled babel-poly…
Nov 17, 2017
32c820f
Let TypeScript process jsx again - should also fix the Jest tests
Nov 19, 2017
34d2011
Replaced babel-polyfill by core-js/es6/symbol
Nov 24, 2017
109b53d
Removed Babel, but keep downlevelIteration and core-js/es6/symbol
Nov 26, 2017
4da0d01
Synced with upstream
Dec 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/react-scripts/config/webpack.config.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ module.exports = {
// This means they will be the "root" imports that are included in JS bundle.
// The first two entry points enable "hot" CSS and auto-refreshes for JS.
entry: [
'core-js/es6/symbol',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd favor to add this polyfill to the general polyfills files instead of this array, esp. regarding maintenance. Would be good to have some kind of comment or a short description of why this is included.

// We ship a few polyfills by default:
require.resolve('./polyfills'),
// Include an alternative client for WebpackDevServer. A client's job is to
Expand Down Expand Up @@ -90,7 +91,18 @@ module.exports = {
// https://github.com/facebookincubator/create-react-app/issues/290
// `web` extension prefixes have been added for better support
// for React Native Web.
extensions: ['.web.ts', '.ts', '.web.tsx', '.tsx', '.web.js', '.mjs', '.js', '.json', '.web.jsx', '.jsx'],
extensions: [
'.web.ts',
'.ts',
'.web.tsx',
'.tsx',
'.web.js',
'.mjs',
'.js',
'.json',
'.web.jsx',
'.jsx',
],
alias: {
// @remove-on-eject-begin
// Resolve Babel runtime relative to react-scripts.
Expand Down
20 changes: 18 additions & 2 deletions packages/react-scripts/config/webpack.config.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,11 @@ module.exports = {
// You can exclude the *.map files from the build during deployment.
devtool: shouldUseSourceMap ? 'source-map' : false,
// In production, we only want to load the polyfills and the app code.
entry: [require.resolve('./polyfills'), paths.appIndexJs],
entry: [
'core-js/es6/symbol',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

require.resolve('./polyfills'),
paths.appIndexJs,
],
output: {
// The build folder.
path: paths.appBuild,
Expand Down Expand Up @@ -96,7 +100,18 @@ module.exports = {
// https://github.com/facebookincubator/create-react-app/issues/290
// `web` extension prefixes have been added for better support
// for React Native Web.
extensions: ['.web.ts', '.ts', '.web.tsx', '.tsx', '.web.js', '.mjs', '.js', '.json', '.web.jsx', '.jsx'],
extensions: [
'.web.ts',
'.ts',
'.web.tsx',
'.tsx',
'.web.js',
'.mjs',
'.js',
'.json',
'.web.jsx',
'.jsx',
],
alias: {
// @remove-on-eject-begin
// Resolve Babel runtime relative to react-scripts.
Expand Down Expand Up @@ -151,6 +166,7 @@ module.exports = {
{
test: /\.(ts|tsx)$/,
include: paths.appSrc,

use: [
{
loader: require.resolve('ts-loader'),
Expand Down
3 changes: 2 additions & 1 deletion packages/react-scripts/template/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"noImplicitAny": true,
"strictNullChecks": true,
"suppressImplicitAnyIndexErrors": true,
"noUnusedLocals": true
"noUnusedLocals": true,
"downlevelIteration": true
},
"exclude": [
"node_modules",
Expand Down