-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmake #151
Open
butjar
wants to merge
16
commits into
wn-upf:master
Choose a base branch
from
butjar:cmake
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cmake #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all Komondor source code from `Code` to `src`. Additionally, fix file permissions since `build_local` was making source code unintentionally executable.
Move source code from Code/COST to COST. Fix file permissions.
Add the source code for Comp++ to CompCpp. Comp++ is the code for building the `cxx` executable that translates `komondor_main.cc` to `komondor_main.cxx`.
Extract the csv file in Code/input and move them to the input directory. The CSV files should not live next to the source code. Fix file permissions.
Move all scripts to a separate folder. The should also not live with the Komondor source code.
Move config_models to a separate folder.
Fix files that have been marked unintentionally executable.
Remove unitentionally checked-in lock files.
Remove artifacts from the CompC++ and Komondor build processes.
Some headers from COST/SENSE are not used by Komondor and can be removed.
Remove the old build script.
Create a Cmake build pipeline for CompC++ and Komondor. The pipeline is a bit unconventional since the CompC++ translation procedure is a bit quirky. The translation requires all included headers to build `komondor_main.cxx` and does not use linking.
Add build instructions to the README.
closes #150 |
Open
The CompC++ build requires flex, add a notice to the build instructions.
- Remove references to `Code` - Exclude the build directory
Add the licensing disclaimer from COST and CompCpp to LICENSE files in the appropriate directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the project structure and adds CMake build pipeline for Komondor.
Komondors source code has not been touched. If you walk through the commits you can see that the source files have only been moved (and permissions have been fixed).
WARNING: The scripts won't work since they have been moved. Maybe you could give a hand in fixing them if you consider to accept this PR.