-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(api): mutable API preliminary work #229
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unused lint errors can be ignored since the API is not public yet. |
Codecov Report
@@ Coverage Diff @@
## main #229 +/- ##
==========================================
+ Coverage 60.20% 60.41% +0.20%
==========================================
Files 38 40 +2
Lines 2699 2766 +67
Branches 664 687 +23
==========================================
+ Hits 1625 1671 +46
- Misses 623 625 +2
- Partials 451 470 +19
|
appcypher
force-pushed
the
appcypher/mut-api
branch
from
May 17, 2023 08:29
ae9f60e
to
f438964
Compare
appcypher
force-pushed
the
appcypher/mut-api
branch
from
June 14, 2023 11:09
9ce56bb
to
1a1cbe5
Compare
matheus23
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Initial work on mutable/ root tree API. There are still some work that needs to be done to complete the API (public/private root merge, blockstore ref only, etc.) but this is as far as we can go right now.
Test plan (required)
scripts/rs-wnfs.sh test
Closing issues