Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): mutable API preliminary work #229

Merged
merged 8 commits into from
Jun 14, 2023
Merged

chore(api): mutable API preliminary work #229

merged 8 commits into from
Jun 14, 2023

Conversation

appcypher
Copy link
Member

Summary

Initial work on mutable/ root tree API. There are still some work that needs to be done to complete the API (public/private root merge, blockstore ref only, etc.) but this is as far as we can go right now.

Test plan (required)

scripts/rs-wnfs.sh test

Closing issues

@appcypher appcypher requested a review from a team as a code owner April 5, 2023 12:59
@appcypher appcypher changed the title Mutable API Prelim chore(api): mutable API preliminary work Apr 5, 2023
@appcypher
Copy link
Member Author

The unused lint errors can be ignored since the API is not public yet.

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #229 (5fa7ac1) into main (2f8ad3f) will increase coverage by 0.20%.
The diff coverage is 63.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
+ Coverage   60.20%   60.41%   +0.20%     
==========================================
  Files          38       40       +2     
  Lines        2699     2766      +67     
  Branches      664      687      +23     
==========================================
+ Hits         1625     1671      +46     
- Misses        623      625       +2     
- Partials      451      470      +19     
Impacted Files Coverage Δ
wnfs/examples/private.rs 0.00% <0.00%> (ø)
wnfs/src/private/forest.rs 68.18% <ø> (+4.54%) ⬆️
wnfs/src/traits.rs 0.00% <0.00%> (ø)
wnfs/src/root_tree.rs 67.69% <67.69%> (ø)

wnfs/src/root_tree.rs Outdated Show resolved Hide resolved
@appcypher appcypher merged commit 24bf412 into main Jun 14, 2023
@appcypher appcypher deleted the appcypher/mut-api branch June 14, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants