-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement previous iterator for subpaths #70
Conversation
Comments, arg order
Codecov Report
@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 64.29% 64.62% +0.33%
==========================================
Files 24 25 +1
Lines 1613 1795 +182
Branches 416 458 +42
==========================================
+ Hits 1037 1160 +123
- Misses 213 233 +20
- Partials 363 402 +39
|
Flipping this to ready-for-review @appcypher, because I'm thinking this is already really useful & the wasm piece is probably another PR in and of itself, and I should probably have webnative & rs-wnfs/wasm side-by-side while working on that (i.e. it'll take a little more time). Do you think that makes sense? |
Yep. Makes sense to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this 🎉. We are step closer to feature parity.
I have a few refactor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starter set of comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need a rebase from main
, but 👍🏽. I updated an outdated comment, but no biggie there either (sorry for not realizing the node history was already in the of
constructor). Thanks for all the updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP because:
PrivateForest
inPrivateNodePathHistory
?WASM bindings?